Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude outdated client-go in go.mod #627

Merged
merged 1 commit into from
Jun 27, 2023
Merged

Exclude outdated client-go in go.mod #627

merged 1 commit into from
Jun 27, 2023

Conversation

acumino
Copy link
Member

@acumino acumino commented Jun 27, 2023

How to categorize this PR?

/area dev-productivity
/kind cleanup

What this PR does / why we need it:
This PR excludes outdated client-go in go.mod. This is the first step to removing the cyclic dependency of k8s.io/[email protected]+incompatible

/invite @ialidzhikov

Which issue(s) this PR fixes:
Part of gardener/gardener#6807

Special notes for your reviewer:

Release note:

NONE

@acumino acumino requested a review from a team as a code owner June 27, 2023 07:53
@gardener-robot gardener-robot added area/dev-productivity Developer productivity related (how to improve development) kind/cleanup Something that is not needed anymore and can be cleaned up needs/review Needs review size/s Size of pull request is small (see gardener-robot robot/bots/size.py) labels Jun 27, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 27, 2023
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jun 27, 2023
@acumino
Copy link
Member Author

acumino commented Jun 27, 2023

/invite @abdasgupta @shreyas-s-rao

ialidzhikov
ialidzhikov approved these changes Jun 27, 2023
View reviewed changes
Copy link
Member

@ialidzhikov ialidzhikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Jun 27, 2023
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 27, 2023
@acumino
Copy link
Member Author

acumino commented Jun 27, 2023

/retest

seshachalam-yv
seshachalam-yv reviewed Jun 27, 2023
View reviewed changes
Copy link
Contributor

@seshachalam-yv seshachalam-yv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

shreyas-s-rao
shreyas-s-rao approved these changes Jun 27, 2023
View reviewed changes
Copy link
Contributor

@shreyas-s-rao shreyas-s-rao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@shreyas-s-rao shreyas-s-rao merged commit 9d68792 into gardener:master Jun 27, 2023
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Jun 27, 2023
@acumino acumino deleted the fix-circular-dep branch June 30, 2023 08:53
shreyas-s-rao pushed a commit to shreyas-s-rao/etcd-druid that referenced this pull request Jul 11, 2023
@acumino @shreyas-s-rao
Exclude outdated client-go in go.mod (gardener#627)
8480d42
@shreyas-s-rao shreyas-s-rao mentioned this pull request Jul 11, 2023
Merged
shreyas-s-rao added a commit that referenced this pull request Jul 12, 2023
@shreyas-s-rao @acumino @unmarshall
Cherry-pick PRs for v0.18.4 (#637)
bd914c9 
* Exclude outdated client-go in `go.mod` (#627)

* Fixes for etcd status fields (#594)

* Use structured log messages (#632)

* Add CVE categorization (#634)

* Print build version and go runtime info (#636)

Co-authored-by: Shreyas Rao <[email protected]>
Co-authored-by: Sonu Kumar Singh <[email protected]>
Co-authored-by: Madhav Bhargava <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seshachalam-yv seshachalam-yv seshachalam-yv left review comments

@ialidzhikov ialidzhikov ialidzhikov approved these changes

@shreyas-s-rao shreyas-s-rao shreyas-s-rao approved these changes

@abdasgupta abdasgupta Awaiting requested review from abdasgupta

Assignees
No one assigned
Labels
area/dev-productivity Developer productivity related (how to improve development) kind/cleanup Something that is not needed anymore and can be cleaned up needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/s Size of pull request is small (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@acumino @ialidzhikov @shreyas-s-rao @seshachalam-yv @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot