Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update etcd-custom-image to v3.4.26-2 #656

Merged
merged 3 commits into from
Aug 29, 2023
Merged

Update etcd-custom-image to v3.4.26-2 #656

merged 3 commits into from
Aug 29, 2023

Conversation

shreyas-s-rao
Copy link
Contributor

@shreyas-s-rao shreyas-s-rao commented Aug 7, 2023 •
edited
Loading

How to categorize this PR?

/area security compliance
/kind enhancement

What this PR does / why we need it:
This PR updates etcd-custom-image to v3.4.26 which runs etcd:v3.4.26. There are no breaking changes from the previous etcd:v3.4.13 version, and it is backward compatible with previous etcd v3.4.x versions.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Update etcd-custom-image to `v3.4.26-2`.

Update alpine base image version to 3.18.3.

@shreyas-s-rao shreyas-s-rao added this to the v0.20.0 milestone Aug 7, 2023
@shreyas-s-rao shreyas-s-rao requested a review from aaronfern August 7, 2023 05:32
@shreyas-s-rao shreyas-s-rao requested a review from a team as a code owner August 7, 2023 05:32
@gardener-robot gardener-robot added area/compliance Compliance related area/security Security related kind/enhancement Enhancement, improvement, extension needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Aug 7, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 7, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 7, 2023
@aaronfern
Copy link
Contributor

/test pull-etcd-druid-e2e-kind

@shreyas-s-rao
Copy link
Contributor Author

/retest

2 similar comments
@shreyas-s-rao
Copy link
Contributor Author

/retest

@shreyas-s-rao
Copy link
Contributor Author

/retest

@aaronfern
Copy link
Contributor

/test pull-etcd-druid-e2e-kind

@shreyas-s-rao
Copy link
Contributor Author

/test pull-etcd-druid-e2e-kind-alpha-features

1 similar comment
@shreyas-s-rao
Copy link
Contributor Author

/test pull-etcd-druid-e2e-kind-alpha-features

@shreyas-s-rao
Copy link
Contributor Author

/needs cherry-pick

@gardener-robot gardener-robot added the needs/cherry-pick Needs to be cherry-picked to older version label Aug 9, 2023
@shreyas-s-rao
Copy link
Contributor Author

/remove needs/cherry-pick

@gardener-robot gardener-robot removed the needs/cherry-pick Needs to be cherry-picked to older version label Aug 9, 2023
@gardener-robot
Copy link

@aaronfern You have pull request review open invite, please check

aaronfern
aaronfern approved these changes Aug 10, 2023
View reviewed changes
Copy link
Contributor

@aaronfern aaronfern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Aug 10, 2023
@gardener-robot gardener-robot added needs/review Needs review and removed reviewed/lgtm Has approval for merging labels Aug 17, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 17, 2023
@shreyas-s-rao
Copy link
Contributor Author

/retest-required

@ishan16696
Copy link
Member

I found etcd version 3.4.26 is using bbolt v1.3.7: https://github.com/etcd-io/etcd/blob/v3.4.26/go.mod#L35
and in backup-restore we are using bbolt v1.3.6: https://github.com/gardener/etcd-backup-restore/blob/master/go.mod#L33
I guess we need to revendor the bbolt in backup-restore and I will open a PR to update bbolt in backup-restore

@ishan16696 ishan16696 mentioned this pull request Aug 18, 2023
Merged
@ishan16696
Copy link
Member

@shreyas-s-rao I have opened a PR: gardener/etcd-backup-restore#659 to revendor the bbolt in backup-restore, If it's not required then feel free to close it.

@gardener-robot
Copy link

@ishan16696 You have pull request review open invite, please check

@ishan16696 ishan16696 self-assigned this Aug 20, 2023
@shreyas-s-rao shreyas-s-rao changed the title Update etcd-custom-image to v3.4.26 Update etcd-custom-image to v3.4.26-2 Aug 28, 2023
@shreyas-s-rao
Copy link
Contributor Author

@ishan16696 the PR is rebased. PTAL

@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 28, 2023
@shreyas-s-rao shreyas-s-rao added the merge/squash Should be merged via 'Squash and merge' label Aug 28, 2023
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 28, 2023
@shreyas-s-rao
Copy link
Contributor Author

/test pull-etcd-druid-e2e-kind-alpha-features
/reviewed ok-to-test

@gardener-robot gardener-robot added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 28, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 28, 2023
@shreyas-s-rao shreyas-s-rao merged commit 75280f2 into gardener:master Aug 29, 2023
@shreyas-s-rao shreyas-s-rao deleted the update/etcd-v3.4.26 branch August 29, 2023 10:02
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ishan16696 ishan16696 ishan16696 approved these changes

@aaronfern aaronfern aaronfern approved these changes

Assignees

@shreyas-s-rao shreyas-s-rao

Labels
area/compliance Compliance related area/security Security related kind/enhancement Enhancement, improvement, extension merge/squash Should be merged via 'Squash and merge' needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
v0.20.0
Development

Successfully merging this pull request may close these issues.
8 participants
@shreyas-s-rao @aaronfern @gardener-robot @ishan16696 @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3 @seshachalam-yv