Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue with local provider for etcd-backup-restore distroless image #662

Merged
merged 1 commit into from
Aug 9, 2023
Merged

Fix issue with local provider for etcd-backup-restore distroless image #662

merged 1 commit into from
Aug 9, 2023

Conversation

aaronfern
Copy link
Contributor

@aaronfern aaronfern commented Aug 8, 2023 •
edited by shreyas-s-rao
Loading

How to categorize this PR?

/kind bug

What this PR does / why we need it:

  1. We found an issue with the etcd pod deploys with the distroless image setup and using the Local provider where the snapshots were saved in a different directory than what was expected.
  2. The etcdcopybackupstask job was not correctly adapted for the Local provider when distroless etcd-backup-restore image was integrated. It also used incorrect snapstore-temp-directory for distroless etcd-backup-restore container.

This PR fixed both these issues

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

A bug causing incorrect volume mount path for `Etcd`s and `EtcdCopyBackupsTask`s using `Local` snapshot storage provider while using distroless etcd-backup-restore image `v0.25.x` has been resolved.

A bug causing `EtcdCopyBackupsTask` jobs to fail to create temp snapshot directory while using distroless etcd-backup-restore image `v0.25.x` has been resolved.

@aaronfern aaronfern requested a review from a team as a code owner August 8, 2023 14:33
@gardener-robot gardener-robot added kind/bug Bug needs/review Needs review size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) labels Aug 8, 2023
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 8, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 8, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 8, 2023
shreyas-s-rao
shreyas-s-rao reviewed Aug 9, 2023
View reviewed changes
Copy link
Contributor

@shreyas-s-rao shreyas-s-rao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aaronfern thanks for the fix! Other than couple of nits, looks good.

controllers/etcdcopybackupstask/reconciler.go Outdated Show resolved Hide resolved
pkg/component/etcd/statefulset/statefulset.go Outdated Show resolved Hide resolved
@shreyas-s-rao shreyas-s-rao added this to the v0.20.0 milestone Aug 9, 2023
@shreyas-s-rao
Copy link
Contributor

/needs cherry-pick

@gardener-robot gardener-robot added the needs/cherry-pick Needs to be cherry-picked to older version label Aug 9, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 9, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 9, 2023
shreyas-s-rao
shreyas-s-rao approved these changes Aug 9, 2023
View reviewed changes
Copy link
Contributor

@shreyas-s-rao shreyas-s-rao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Aug 9, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 9, 2023
@shreyas-s-rao
Copy link
Contributor

/test pull-etcd-druid-e2e-kind

@shreyas-s-rao
Copy link
Contributor

/test pull-etcd-druid-e2e-kind-alpha-features

@shreyas-s-rao
Copy link
Contributor

/test pull-etcd-druid-e2e-kind-alpha-features

@shreyas-s-rao
Copy link
Contributor

/test pull-etcd-druid-e2e-kind

@shreyas-s-rao
Copy link
Contributor

/test pull-etcd-druid-e2e-kind-alpha-features

1 similar comment
@shreyas-s-rao
Copy link
Contributor

/test pull-etcd-druid-e2e-kind-alpha-features

@shreyas-s-rao shreyas-s-rao changed the title Fix issue with local provider for etcd-wrapper distroless image Fix issue with local provider for etcd-backup-restore distroless image Aug 9, 2023
@shreyas-s-rao shreyas-s-rao merged commit 7dd3afe into gardener:master Aug 9, 2023
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Aug 9, 2023
shreyas-s-rao pushed a commit to shreyas-s-rao/etcd-druid that referenced this pull request Aug 9, 2023
@aaronfern @shreyas-s-rao
Fix issue with Local provider for etcd-backup-restore distroless image (
be17a45 
gardener#662)
@shreyas-s-rao shreyas-s-rao mentioned this pull request Aug 9, 2023
Merged
shreyas-s-rao pushed a commit to shreyas-s-rao/etcd-druid that referenced this pull request Aug 9, 2023
@aaronfern @shreyas-s-rao
Fix issue with Local provider for etcd-backup-restore distroless image (
c6e89f3 
gardener#662)
shreyas-s-rao added a commit that referenced this pull request Aug 9, 2023
@shreyas-s-rao @aaronfern
[hotfix-0.19] Fix issue with Local provider for etcd-backup-restore d…
dda8128 
…istroless image (#662) and fix failing e2e-test infra setup job (#661) (#663)

* Fix failing e2e-test infra setup job (#661)

* Fix issue with Local provider for etcd-backup-restore distroless image (#662)

---------

Co-authored-by: Aaron Francis Fernandes <[email protected]>
Co-authored-by: Shreyas Rao <[email protected]>
@ishan16696 ishan16696 mentioned this pull request Aug 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shreyas-s-rao shreyas-s-rao shreyas-s-rao approved these changes

Assignees

@aaronfern aaronfern

Labels
kind/bug Bug needs/cherry-pick Needs to be cherry-picked to older version needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
v0.20.0
Development

Successfully merging this pull request may close these issues.
6 participants
@aaronfern @shreyas-s-rao @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot