Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop support for PodDisruptionBudgets with API version policy/v1beta1 #681

Merged
merged 3 commits into from
Oct 3, 2023
Merged

Drop support for PodDisruptionBudgets with API version policy/v1beta1 #681

merged 3 commits into from
Oct 3, 2023

Conversation

aaronfern
Copy link
Contributor

How to categorize this PR?

/area control-plane
/kind api-change
/kind cleanup

What this PR does / why we need it:
PodDisruptionBudgets from API version policy/v1beta1 were deprecated from k8s v1.21.x onwards and were available as part of API version policy/v1
With #430, etcd-druid supported PodDisruptionBudgets from both the API versions depending on the k8s version used and this feature was eventually meant to be dropped

This PR drops support for PodDisruptionBudget policy/v1beta1

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Etcd druid will now not support `policy/v1beta1` for `PodDisruptionBudget`s and will only use `policy/v1` for `PodDisruptionBudget`s

@aaronfern aaronfern requested a review from a team as a code owner September 15, 2023 11:44
@gardener-robot gardener-robot added area/control-plane Control plane related kind/api-change API change with impact on API users kind/cleanup Something that is not needed anymore and can be cleaned up needs/review Needs review size/l Size of pull request is large (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else labels Sep 15, 2023
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 15, 2023
shreyas-s-rao
shreyas-s-rao requested changes Sep 15, 2023
View reviewed changes
Copy link
Contributor

@shreyas-s-rao shreyas-s-rao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aaronfern thanks a lot for this PR. Can you please add a doc stating that druid supports k8s versions > 1.21? A new doc will be required.

I have one question about the previous code. PTAL, thanks

pkg/component/etcd/poddisruptionbudget/poddisruptionbudget.go Show resolved Hide resolved
@gardener-robot gardener-robot added the needs/changes Needs (more) changes label Sep 15, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 25, 2023
@aaronfern
Copy link
Contributor Author

/test pull-etcd-druid-e2e-kind-alpha-features

@shreyas-s-rao shreyas-s-rao self-assigned this Sep 26, 2023
shreyas-s-rao
shreyas-s-rao requested changes Sep 29, 2023
View reviewed changes
Copy link
Contributor

@shreyas-s-rao shreyas-s-rao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aaronfern thanks for adding the doc. Please check and make these minor changes. Otherwise, lgtm

docs/usage/supported_k8s_versions.md Outdated Show resolved Hide resolved
.docforge/manifest.yaml Outdated Show resolved Hide resolved
@aaronfern @shreyas-s-rao
Updated docs
676978f 
Co-authored-by: Shreyas Rao <[email protected]>
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Oct 3, 2023
@shreyas-s-rao shreyas-s-rao added this to the v0.20.0 milestone Oct 3, 2023
shreyas-s-rao
shreyas-s-rao approved these changes Oct 3, 2023
View reviewed changes
Copy link
Contributor

@shreyas-s-rao shreyas-s-rao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/changes Needs (more) changes needs/review Needs review needs/second-opinion Needs second review by someone else labels Oct 3, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Oct 3, 2023
@shreyas-s-rao shreyas-s-rao merged commit b153add into gardener:master Oct 3, 2023
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Oct 3, 2023
acumino
acumino reviewed Oct 3, 2023
View reviewed changes
docs/usage/supported_k8s_versions.md

| Etcd-druid version | Kubernetes version |
|------|------|
| >=0.20 | >=1.25 |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This says druid of version >=0.20 doesn't support Kubernetes version 1.24. We are planning to support 1.24 in Gardener till the end of the year or later. Will the 0.20 release of the druid will come after the end of this year?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an error in the doc
etcd-druid >=0.20 should support k8s versions >=1.21. Thanks for pointing this out, we will update this doc

etcd-druid:v0.20 will be released this year, and gardener should have no problem supporting it :)

@aaronfern aaronfern deleted the remove_pdb_v1beta branch October 3, 2023 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acumino acumino acumino left review comments

@shreyas-s-rao shreyas-s-rao shreyas-s-rao approved these changes

Assignees

@aaronfern aaronfern

Labels
area/control-plane Control plane related kind/api-change API change with impact on API users kind/cleanup Something that is not needed anymore and can be cleaned up needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/l Size of pull request is large (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
v0.20.0
Development

Successfully merging this pull request may close these issues.
7 participants
@aaronfern @acumino @shreyas-s-rao @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot