Stop watching leases for custodian controller #688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
area/quality
gardener-robot-ci-3
added
reviewed/ok-to-test
shreyas-s-rao
force-pushed
the
fix/custodian-requeue
branch
from
eb2522d to
747be03
Compare
gardener-robot-ci-1
added
reviewed/ok-to-test
|
@unmarshall, @seshachalam-yv You have pull request review open invite, please check |
unmarshall
reviewed
Oct 2, 2023
gardener-robot-ci-1
added
the
reviewed/ok-to-test
gardener-robot-ci-3
removed
the
reviewed/ok-to-test
shreyas-s-rao
force-pushed
the
fix/custodian-requeue
branch
from
b1958b9 to
f225e10
Compare
gardener-robot-ci-1
added
the
reviewed/ok-to-test
gardener-robot-ci-3
removed
the
reviewed/ok-to-test
|
/test pull-etcd-druid-e2e-kind-alpha-features |
gardener-robot-ci-3
added
reviewed/ok-to-test
|
@unmarshall thanks for your comments. I have addressed them. PTAL |
|
/retest |
|
/test pull-etcd-druid-e2e-kind |
gardener-robot-ci-3
added
reviewed/ok-to-test
gardener-robot
added
reviewed/lgtm
gardener-robot-ci-3
added
the
reviewed/ok-to-test
seshachalam-yv
approved these changes
Oct 3, 2023
There was a problem hiding this comment.
Thanks @shreyas-s-rao Nice Fix
Saving a lot KAPI calls 🚀
/lgtm
gardener-robot
added
the
status/closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area quality
/kind bug
What this PR does / why we need it:
Custodian controller no longer watches lease objects, but rather does an initial reconciliation on any etcd object that has finished reconciliation, and requeues the event for after
SyncPeriodinterval, as was being done previously as well.This PR ensures that custodian controller does not update the etcd status too frequently, thus saving hundreds of calls to kube-apiserver every second per seed cluster, not to mention the reduction in number of failed etcd status update calls from etcd controller to update
observedGenerationandlastErrorinformation.Additionally, the predicate
EtcdReconciliationFinishedhas been modified to check equality ofstatus.ObservedGenerationandmetadata.Generation, rather thanstatus.Ready. Reason for this is that reconciliation is technically finished only when etcd reconciler marks the observedGeneration with the generation it "observes", and has nothing to do with whether the etcd cluster is ready or not.Which issue(s) this PR fixes:
Fixes #683
Special notes for your reviewer:
/invite @unmarshall @seshachalam-yv
/assign @unmarshall @seshachalam-yv
Release note: