Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[hotfix-v0.23] Update etcd-druid documentation and enhance kind-up script to start a local kind registry container #903

Merged
merged 1 commit into from
Oct 29, 2024
Merged

[hotfix-v0.23] Update etcd-druid documentation and enhance kind-up script to start a local kind registry container #903

merged 1 commit into from
Oct 29, 2024

Conversation

unmarshall
Copy link
Contributor

How to categorize this PR?

/area dev-productivity
/area documentation
/kind enhancement

What this PR does / why we need it:
Cherry picks #889

Release note:

* Updates etcd-druid documentation
* Enhances hack/kind-up.sh script with additional capability to set feature-gates and launch local docker container registry.

* If you use `make kind-up` to bring up a local kind cluster then please note that the kubeconfig is now written to hack/kind/kubeconfig.

@unmarshall
Update etcd-druid documentation and enhance kind-up script to start a…
6239bfb 
… local kind registry container (gardener#889)

Improved etcd-druid documentation and enhanced hack/kind-up.sh script
@unmarshall unmarshall requested a review from a team as a code owner October 29, 2024 09:31
@gardener-robot gardener-robot added area/dev-productivity Developer productivity related (how to improve development) area/documentation Documentation related kind/enhancement Enhancement, improvement, extension needs/review Needs review size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else labels Oct 29, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Oct 29, 2024
@unmarshall unmarshall changed the title Update etcd-druid documentation and enhance kind-up script to start a local kind registry container [hotfix-v0.23] Update etcd-druid documentation and enhance kind-up script to start a local kind registry container Oct 29, 2024
anveshreddy18
anveshreddy18 approved these changes Oct 29, 2024
View reviewed changes
Copy link
Contributor

@anveshreddy18 anveshreddy18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !!

@unmarshall unmarshall merged commit b31c378 into gardener:hotfix-v0.23 Oct 29, 2024
11 checks passed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Oct 29, 2024
@unmarshall unmarshall deleted the cherrypick-889 branch December 12, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anveshreddy18 anveshreddy18 anveshreddy18 approved these changes

@renormalize renormalize renormalize approved these changes

Assignees
No one assigned
Labels
area/dev-productivity Developer productivity related (how to improve development) area/documentation Documentation related kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review needs/second-opinion Needs second review by someone else size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@unmarshall @renormalize @anveshreddy18 @gardener-robot-ci-3 @gardener-robot