Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove VPA for the csi-disk-plugin-alicloud DaemonSet #750

Merged
merged 2 commits into from
Jan 20, 2025
Merged

Remove VPA for the csi-disk-plugin-alicloud DaemonSet #750

merged 2 commits into from
Jan 20, 2025

Conversation

ialidzhikov
Copy link
Member

@ialidzhikov ialidzhikov commented Dec 18, 2024 •
edited
Loading

How to categorize this PR?

/area auto-scaling
/kind enhancement
/platform alicloud

What this PR does / why we need it:
Similar to gardener/gardener-extension-provider-gcp#929

Which issue(s) this PR fixes:
N/A

Special notes for your reviewer:
N/A

Release note:

The kube-system/csi-disk-plugin-alicloud DaemonSet is no longer scaled by a VerticalPodAutoscaler as it does not really benefit from it. Removing VerticalPodAutoscaler for that component will reduce unnecessary evictions by VPA and will be a mitigation for https://issues.k8s.io/126921.

The kube-system/csi-disk-plugin-alicloud DaemonSet does no longer specify resource limits.

@ialidzhikov ialidzhikov requested review from a team as code owners December 18, 2024 13:58
@ialidzhikov ialidzhikov marked this pull request as draft December 18, 2024 13:59
@gardener-robot gardener-robot added area/auto-scaling Auto-scaling (CA/HPA/VPA/HVPA, predominantly control plane, but also otherwise) related kind/enhancement Enhancement, improvement, extension platform/alicloud Alicloud platform/infrastructure needs/review Needs review size/s Size of pull request is small (see gardener-robot robot/bots/size.py) labels Dec 18, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Dec 18, 2024
@ialidzhikov ialidzhikov changed the title Fix/remove vpa for csi driver node Remove VPA for the csi-disk-plugin-alicloud DaemonSet Dec 18, 2024
@ialidzhikov ialidzhikov marked this pull request as ready for review December 18, 2024 15:17
@ialidzhikov ialidzhikov marked this pull request as draft December 18, 2024 17:21
@ialidzhikov ialidzhikov marked this pull request as ready for review December 19, 2024 11:51
@ialidzhikov
Copy link
Member Author

I am sorry for all the back and forth with PR (marking ready for review and then draft).

tl;dr: It should be safe to remove VPA for the csi node plugin DaemonSet. The PR is ready for review!

@ialidzhikov ialidzhikov force-pushed the fix/remove-vpa-for-csi-driver-node branch from 574ce38 to 1b9b762 Compare January 6, 2025 07:59
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 6, 2025
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 6, 2025
@ialidzhikov
Copy link
Member Author

@shaoyongfeng , could you please check the PR? Thanks in advance!

@shaoyongfeng shaoyongfeng merged commit a551cb1 into gardener:master Jan 20, 2025
10 checks passed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Jan 20, 2025
@ialidzhikov ialidzhikov deleted the fix/remove-vpa-for-csi-driver-node branch January 23, 2025 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shaoyongfeng shaoyongfeng shaoyongfeng approved these changes

Assignees
No one assigned
Labels
area/auto-scaling Auto-scaling (CA/HPA/VPA/HVPA, predominantly control plane, but also otherwise) related kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review platform/alicloud Alicloud platform/infrastructure size/s Size of pull request is small (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ialidzhikov @shaoyongfeng @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot