Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add deletecollection verb to RBAC rules #1208

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add deletecollection verb to RBAC rules #1208

wants to merge 2 commits into from

Conversation

AleksandarSavchev
Copy link
Member

@AleksandarSavchev AleksandarSavchev commented Jan 29, 2025 •
edited
Loading

How to categorize this PR?

/area security
/area compliance
/kind enhancement
/platform aws

What this PR does / why we need it:
Add deletecollection verb to RBAC rules where it is required.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

NONE

@AleksandarSavchev AleksandarSavchev requested review from a team as code owners January 29, 2025 14:15
@gardener-robot gardener-robot added needs/review Needs review area/security Security related platform/aws Amazon web services platform/infrastructure labels Jan 29, 2025
@gardener-robot
Copy link

@AleksandarSavchev Label kind/compliance does not exist.

@gardener-robot gardener-robot added the size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) label Jan 29, 2025
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 29, 2025
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jan 29, 2025
@gardener-robot gardener-robot added area/compliance Compliance related kind/enhancement Enhancement, improvement, extension labels Jan 29, 2025
AndreasBurger
AndreasBurger previously approved these changes Jan 29, 2025
View reviewed changes
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jan 29, 2025
@AleksandarSavchev AleksandarSavchev force-pushed the RBAC-add-verb-deletecollection branch from 781ae8f to a78045e Compare February 3, 2025 10:11
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Feb 3, 2025
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Feb 3, 2025
kon-angelo
kon-angelo approved these changes Feb 6, 2025
View reviewed changes
Copy link
Contributor

@kon-angelo kon-angelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kon-angelo
Copy link
Contributor

/needs rebase

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging needs/rebase Needs git rebase and removed needs/review Needs review reviewed/lgtm Has approval for merging labels Feb 6, 2025
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kon-angelo kon-angelo kon-angelo approved these changes

@AndreasBurger AndreasBurger AndreasBurger left review comments

Assignees
No one assigned
Labels
area/compliance Compliance related area/security Security related kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/rebase Needs git rebase platform/aws Amazon web services platform/infrastructure reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@AleksandarSavchev @gardener-robot @kon-angelo @AndreasBurger @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3