Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ci:component:github.com/gardener/machine-controller-manager:0.11.0->0.12.0] #700

Merged
merged 1 commit into from
Jan 31, 2019
Merged

[ci:component:github.com/gardener/machine-controller-manager:0.11.0->0.12.0] #700

merged 1 commit into from
Jan 31, 2019

Conversation

gardener-robot-ci-1
Copy link
Contributor

@gardener-robot-ci-1 gardener-robot-ci-1 commented Jan 30, 2019 •
edited by rfranzke
Loading

Release Notes:

Azure now powers off VM before deletion

Fixes documentation while running CLI client

Leader election defaults were updated

Metrics endpoint is enhanced.

Vendored K8s version 1.12

Add support for Packet cloud provider https://www.packet.com

Prefers scheduling of pods on newer machines during roll-outs

@gardener-robot-ci-1 gardener-robot-ci-1 requested a review from a team as a code owner January 30, 2019 14:27
@rfranzke rfranzke added kind/enhancement Enhancement, improvement, extension status/under-investigation size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. platform/all area/quality Output qualification (tests, checks, scans, automation in general, etc.) related topology/seed Affects Seed clusters labels Jan 31, 2019
@prashanth26
Copy link

prashanth26 commented Jan 31, 2019 •
edited
Loading

Hi @rfranzke .

This looks good to me. However, there is a release note missing due to the CI merge issue while making a rebase and merge. Refer this gardener/machine-controller-manager#202. I have added the message here, can you kindly add it to the PR description as well? As I don't have enough permissions on the Gardener repo.

Prefers scheduling of pods on newer machines during roll-outs

rfranzke
rfranzke approved these changes Jan 31, 2019
View reviewed changes
Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@prashanth26 done

prashanth26
prashanth26 approved these changes Jan 31, 2019
View reviewed changes
Copy link

@prashanth26 prashanth26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@rfranzke rfranzke merged commit cd28b1f into master Jan 31, 2019
@rfranzke rfranzke deleted the ci-xdtjojoyd branch January 31, 2019 08:26
@gardener-robot gardener-robot added priority/3 Priority (lower number equals higher priority) and removed priority/3 Priority (lower number equals higher priority) labels Mar 8, 2021
ialidzhikov pushed a commit to ialidzhikov/gardener that referenced this pull request Aug 1, 2024
@grolu
log filtered cloudprofiles (gardener#700)
26b94de 
* log filtered cloudprofiles

* use logger
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prashanth26 prashanth26 prashanth26 approved these changes

@rfranzke rfranzke rfranzke approved these changes

@hardikdr hardikdr Awaiting requested review from hardikdr

Assignees

@hardikdr hardikdr

@prashanth26 prashanth26

Labels
area/quality Output qualification (tests, checks, scans, automation in general, etc.) related kind/enhancement Enhancement, improvement, extension platform/all size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. topology/seed Affects Seed clusters
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gardener-robot-ci-1 @prashanth26 @rfranzke @hardikdr @gardener-robot