Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: can't add non image disk on GCP #124

Merged
merged 1 commit into from
Jul 24, 2018

Conversation

spheromak
Copy link
Contributor

Solution: Only the root disk on GCP has an image requirement. You can
attach other block storage without a source image, and this change
allows for that.

Solution: Only the root disk on GCP has an image requirement. You can
attach other block storage without a source image, and this change
allows for that.
@spheromak spheromak requested a review from a team as a code owner July 23, 2018 17:21
@CLAassistant
Copy link

CLAassistant commented Jul 23, 2018

CLA assistant check
All committers have signed the CLA.

@hardikdr
Copy link
Member

hardikdr commented Jul 24, 2018

Thanks for the PR.
Generally we expect that application instance would request a non-boot disk via PVC/PV mechanism and MCM would not create any in-parallel to boot-disk.
I am curious if you have any specific use-case for this.[eg. local-storage]

Though PR looks good to me, just a side-note would be that extra non-boot disks could potentially become orphan if VM is lost and AutoDelete is not set to true. Essentially there is no way for MCM/Kubernetes to garbage-collect those Disks due to lack of metadata.

@hardikdr hardikdr merged commit 5976512 into gardener:master Jul 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants