Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed any unwanted re-enqueuing of machine objects #139

Merged
merged 2 commits into from
Aug 16, 2018
Merged

Removed any unwanted re-enqueuing of machine objects #139

merged 2 commits into from
Aug 16, 2018

Conversation

prashanth26
Copy link
Contributor

What this PR does / why we need it:

  • There were several places where machine objects were re-enqueued unwantedly
  • This lead to several reconcilation loops and objects being updated frequently
  • This commit removes any such code

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Removed any unwanted re-enqueuing/re-conciliation of machine objects

@prashanth26
Removed any unwanted re-enqueuing of machine objects
4516e16 
- There were several places where machine objects were re-enqueued unwantedly
- This lead to several reconcilation loops and objects being updated frequently
- This commit removes any such code
@prashanth26 prashanth26 added priority/critical Needs to be resolved soon, because it impacts users negatively needs/review Needs review size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) component/machine-controller-manager platform/all area/quality Output qualification (tests, checks, scans, automation in general, etc.) related kind/cleanup Something that is not needed anymore and can be cleaned up area/dev-productivity Developer productivity related (how to improve development) topology/seed Affects Seed clusters labels Aug 16, 2018
@prashanth26 prashanth26 requested a review from a team as a code owner August 16, 2018 13:11
@prashanth26 prashanth26 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 16, 2018
@ccwienk ccwienk added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 16, 2018
@prashanth26 prashanth26 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 16, 2018
@ccwienk ccwienk added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 16, 2018
@prashanth26 prashanth26 merged commit a80bc6c into gardener:master Aug 16, 2018
@prashanth26 prashanth26 deleted the removed-unwanted-reconcilations branch August 16, 2018 15:10
@prashanth26 prashanth26 added the kind/bug Bug label Aug 21, 2018
@ghost ghost added the component/mcm Machine Controller Manager (including Node Problem Detector, Cluster Auto Scaler, etc.) label Mar 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hardikdr hardikdr hardikdr approved these changes

Assignees
No one assigned
Labels
area/dev-productivity Developer productivity related (how to improve development) area/quality Output qualification (tests, checks, scans, automation in general, etc.) related component/mcm Machine Controller Manager (including Node Problem Detector, Cluster Auto Scaler, etc.) kind/bug Bug kind/cleanup Something that is not needed anymore and can be cleaned up needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review platform/all priority/critical Needs to be resolved soon, because it impacts users negatively size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) topology/seed Affects Seed clusters
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@prashanth26 @hardikdr @ccwienk