Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

indicate proper path to managevm cli #204

Merged
merged 1 commit into from
Dec 18, 2018
Merged

indicate proper path to managevm cli #204

merged 1 commit into from
Dec 18, 2018

Conversation

deitch
Copy link
Contributor

@deitch deitch commented Dec 18, 2018 •
edited by prashanth26
Loading

What this PR does / why we need it:

The doc for local setup has the wrong path to managevm, which, apparently, was renamed.

Which issue(s) this PR fixes:

Special notes for your reviewer:

Release note:

Fixes documentation while running CLI client

@deitch deitch requested review from ggaurav10 and a team as code owners December 18, 2018 09:14
@deitch deitch mentioned this pull request Dec 18, 2018
Merged
@prashanth26 prashanth26 added size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) area/documentation Documentation related status/accepted Issue was accepted as something we need to work on component/machine-controller-manager reviewed/lgtm Has approval for merging kind/cleanup Something that is not needed anymore and can be cleaned up labels Dec 18, 2018
prashanth26
prashanth26 approved these changes Dec 18, 2018
View reviewed changes
Copy link
Contributor

@prashanth26 prashanth26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@prashanth26 prashanth26 merged commit 17f6cdd into gardener:master Dec 18, 2018
@deitch deitch deleted the fix-doc branch December 18, 2018 09:29
@ghost ghost added the component/mcm Machine Controller Manager (including Node Problem Detector, Cluster Auto Scaler, etc.) label Mar 7, 2020
@gardener-robot gardener-robot added priority/3 Priority (lower number equals higher priority) and removed priority/3 Priority (lower number equals higher priority) labels Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prashanth26 prashanth26 prashanth26 approved these changes

@ggaurav10 ggaurav10 Awaiting requested review from ggaurav10

Assignees
No one assigned
Labels
area/documentation Documentation related component/mcm Machine Controller Manager (including Node Problem Detector, Cluster Auto Scaler, etc.) kind/cleanup Something that is not needed anymore and can be cleaned up reviewed/lgtm Has approval for merging size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/accepted Issue was accepted as something we need to work on
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@deitch @prashanth26 @gardener-robot