Machine CRDs now makes use of status subresource #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prashanth26
added
kind/bug
gardener-robot-ci-1
added
needs/ok-to-test
hardikdr
approved these changes
Feb 14, 2019
prashanth26
added a commit
that referenced
this pull request
Feb 15, 2019
This reverts commit 4018eb9.
prashanth26
added a commit
that referenced
this pull request
Feb 15, 2019
gardener-robot
added
the
area/ops-productivity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
With the newer versions of Kubernetes 1.13.x +, CRDs are expected to be built with status subresources else it leads to unwanted generations.
Which issue(s) this PR fixes:
Fixes #220
Special notes for your reviewer:
Release note: