Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix: Removed null pointer exception on Azure #232

Merged
merged 1 commit into from
Feb 28, 2019
Merged

Bugfix: Removed null pointer exception on Azure #232

merged 1 commit into from
Feb 28, 2019

Conversation

prashanth26
Copy link
Contributor

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #231

Special notes for your reviewer:

Release note:

Removes null pointer exception on Azure

@prashanth26 prashanth26 added kind/bug Bug priority/critical Needs to be resolved soon, because it impacts users negatively exp/beginner Issue that requires only basic skills platform/az size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/in-progress Issue is in progress/work topology/seed Affects Seed clusters labels Feb 25, 2019
@prashanth26 prashanth26 requested review from ggaurav10 and a team as code owners February 25, 2019 12:05
@prashanth26 prashanth26 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Feb 25, 2019
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Feb 25, 2019
@prashanth26
Copy link
Contributor Author

HI @rfranzke ,

Like you mentioned I was able to reproduce the issue by deleting the resource group on Azure. The above PR fixes the issue.

@prashanth26 prashanth26 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Feb 26, 2019
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Feb 26, 2019
@prashanth26 prashanth26 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Feb 26, 2019
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Feb 26, 2019
@prashanth26 prashanth26 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Feb 27, 2019
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Feb 27, 2019
@hardikdr hardikdr merged commit 1b0879a into gardener:master Feb 28, 2019
@prashanth26 prashanth26 deleted the bugfix/azure-npe branch March 5, 2019 10:34
@ghost ghost added component/mcm Machine Controller Manager (including Node Problem Detector, Cluster Auto Scaler, etc.) platform/azure Microsoft Azure platform/infrastructure labels Mar 7, 2020
@gardener-robot gardener-robot added the area/ops-productivity Operator productivity related (how to improve operations) label Jun 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hardikdr hardikdr hardikdr approved these changes

@ggaurav10 ggaurav10 Awaiting requested review from ggaurav10

Assignees
No one assigned
Labels
area/ops-productivity Operator productivity related (how to improve operations) component/mcm Machine Controller Manager (including Node Problem Detector, Cluster Auto Scaler, etc.) exp/beginner Issue that requires only basic skills kind/bug Bug needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) platform/azure Microsoft Azure platform/infrastructure priority/critical Needs to be resolved soon, because it impacts users negatively size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/in-progress Issue is in progress/work topology/seed Affects Seed clusters
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NPE on Azure Machine Creations
4 participants
@prashanth26 @hardikdr @gardener-robot-ci-1 @gardener-robot