Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add refund and more tests #10

Merged
merged 5 commits into from
Jun 18, 2024
Merged

Add refund and more tests #10

merged 5 commits into from
Jun 18, 2024

Conversation

Revantark
Copy link
Collaborator

Changelog:

  1. Move Initiate into GardenHTLC
  2. Add Refund logic
  3. Refactor errors
  4. Add more tests to cover errors

yash1io
yash1io reviewed Jun 18, 2024
View reviewed changes
bitcoin/htlc.test.ts Outdated
const aliceHTLC = await GardenHTLC.from(
alice,
secretHash,
alicePubkeyHash,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be alicePubkey

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alicePubkeyHash is actually the pubkey itself. Changed the variable names to pubkeys. Done

@yash1io yash1io merged commit f73c48d into feat/bitcoin Jun 18, 2024
@yash1io yash1io deleted the feat/refund branch June 18, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yash1io yash1io yash1io left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Revantark @yash1io