Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/oss #17

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Feat/oss #17

wants to merge 7 commits into from

Conversation

r4reetik
Copy link
Contributor

No description provided.

Copy link

github-actions bot commented Jun 26, 2024

Slither report

THIS CHECKLIST IS NOT COMPLETE. Use --show-ignored-findings to show all the results.
Summary

suicidal

Impact: High
Confidence: High

function settle() external {
require(expiration > 0, "FeeAccount: no claim");
require(expiration <= block.number, "FeeAccount: claim not expired");
closeChannel(amount);
}

function close(uint256 amount_, bytes memory funderSig, bytes memory recipientSig) external {
bytes32 id = _hashTypedDataV4(keccak256(abi.encode(CLOSE_TYPEHASH, amount_)));
address funderSigner = id.recover(funderSig);
address recipientSigner = id.recover(recipientSig);
require(funderSigner == funder, "FeeAccount: invalid funder signature");
require(recipientSigner == recipient, "FeeAccount: invalid recipient signature");
closeChannel(amount_);
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant