Skip to content

Commit

Permalink
Preserve file permissions
Browse files Browse the repository at this point in the history
I've found that at least a couple of the packages don't work due to internal
files losing their executable permissions. The recommended fix is to tar the
files before uploading to github. Workaround is documented here:
https://github.com/actions/upload-artifact#maintaining-file-permissions-and-case-sensitive-files.

See actions/upload-artifact#38.
  • Loading branch information
garfieldnate committed Aug 6, 2024
1 parent 703d47e commit b6eec9e
Showing 1 changed file with 8 additions and 2 deletions.
10 changes: 8 additions & 2 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,15 @@ jobs:
- name: Package
run: ./gradlew jpackage --no-daemon

# Required to preserve permissions; otherwise many of the packages will not work!
# See https://github.com/actions/upload-artifact#maintaining-file-permissions-and-case-sensitive-files
- name: Tar packages
run: tar -cvf build-artifacts-${{ matrix.os }}.tar build/jpackage/

- name: Archive build artifacts
if: success() # Only runs if the previous steps were successful
# Only runs if the previous steps were successful
if: success()
uses: actions/upload-artifact@v2
with:
name: build-artifacts-${{ matrix.os }}
path: build/jpackage/*
path: build-artifacts-${{ matrix.os }}.tar

0 comments on commit b6eec9e

Please sign in to comment.