Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Python3 #73

Closed
wjo1212 opened this issue Jun 27, 2016 · 2 comments
Closed

Support Python3 #73

wjo1212 opened this issue Jun 27, 2016 · 2 comments

Comments

@wjo1212
Copy link
Contributor

wjo1212 commented Jun 27, 2016

running unit test cases with Py3, failed due to a MD5 compare checking in context.py

wjo1212 pushed a commit to wjo1212/kappa that referenced this issue Jun 27, 2016
@wjo1212
Copy link
Contributor Author

wjo1212 commented Jun 27, 2016

root cause of the issue:
In Py3, passed in str (unicode format) and returned it in bytes type.
detail: http://pythoncentral.io/encoding-and-decoding-strings-in-python-3-x/

fix:
decode it back to str type in Py3, no impact in Py2

test and passed the unit test cases with both Py2 and Py3.4.1 (the fixing should be compatible with all Py3 versions)

@josegonzalez
Copy link
Contributor

I'll have tests run and then merge/release :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants