Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow deploys with existing role #96

Merged
merged 1 commit into from
Jan 30, 2017
Merged

Conversation

wvidana
Copy link
Contributor

@wvidana wvidana commented Dec 19, 2016

This code allows deploying Lambda using an existing role (instead of creating a new one).

  • No policy needed
  • Use role name

Note: tried to update new test for this functionality, but got some problems (too deep recursion) on placebo package. Anyways, editing the foo/kappa.yml to use a role instead of a policy worked (tests passed).

A kappa.yml example would be:

---
name: kappa-simple
environments:
  dev:
    profile: foobar
    region: us-west-2
    role:
      name: foo-the-role
lambda:    
  description: Foo the Bar
  handler: simple.handler
  runtime: python2.7
  memory_size: 256
  timeout: 3

@wvidana
Copy link
Contributor Author

wvidana commented Dec 19, 2016

Solves #83

@zzsnzmn
Copy link

zzsnzmn commented Jan 26, 2017

Anything else needed to get this merged? Would be happy to assist.

@josegonzalez
Copy link
Contributor

Needs docs.

 * No policy needed
 * Use role name
@wvidana
Copy link
Contributor Author

wvidana commented Jan 30, 2017

Just added that example on the PR description the the sample code folder

@josegonzalez josegonzalez merged commit 9fb9aac into garnaat:develop Jan 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants