Adding support for environment variables #97
Conversation
When configuring the S3 bucket event the function `add` builds the `LambdaFunctionConfigurations` which specifies the `LambdaFunctionArn`. The ARN should be the functions *exact* ARN and not suffixed by the environment ex.`arn:aws:lambda:us-west-1:1234567890123:function:bigquery_commit:main-env`. It makes the Lambda UI and the S3 event sources UI confused as they don't recognize that the specific Lambda function even exists. The reason why I made this change is because I had problems applying the bucket event cross-account and could not do this without this change.
…ger to show multiple times in AWS console
SNS events need to be given the lambdaInvoke permission so that they can call the lambda function. Fixes garnaat#76.
|
I'm not sure why 8 other commits were bundled in here, since I forked from the main repository lately. Any idea? |
|
You probably branched from master and are pull requesting to develop. |
|
Nah they're both from develop - "BrunoCarrier wants to merge 9 commits into garnaat:develop from BrunoCarrier:develop" |
|
@josegonzalez @garnaat, is there anything needing to be done so that this is included in the next release? Is there an ETA for the next release? |
|
ETA is whenever someone gets to it. I have a day job that pays bills, open source does not. I'll look at this when I get a chance. Note: you'll need to figure out how to remove all those extra commits from the pull request. |
|
@josegonzalez That sounds good and is absolutely understandable :-) I appreciate the reply I've fixed the extra commits issue through this other pull request:#98 Consequently, I will close this current PR |
Hi, this pull request allows for environment variables to be used
At the environment level, if the environment_variables key is present with a dictionary, it will add it to the update_configuration and create methods. Otherwise, it will send blank data which effectively removes any existing environment variables
The _check_config_md5 method will also consider changes in the yml file, and will update lambda function configuration if any change is detected
I added an example to the kamma-simple project