Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version 0.4.0 stop working #34

Closed
facundocabrera opened this issue Feb 9, 2015 · 6 comments · Fixed by #1523
Closed

Version 0.4.0 stop working #34

facundocabrera opened this issue Feb 9, 2015 · 6 comments · Fixed by #1523
Assignees
@garris
Labels
question

Comments

@facundocabrera
Copy link

Hey,

I did not review all the changes between 0.3.0 and 0.4.0, but seems the basic command gulp reference is throwing:

[15:21:09] Finished 'reference' after 5.04 ms
CasperJS: CREATING NEW REFERENCE FILES
CasperJS: CasperError: No steps defined, aborting
CasperJS: /usr/lib/node_modules/casperjs/modules/casper.js:1505 in run
/home/user/projects/myCoolProject/node_modules/backstopjs/capture/genBitmaps.js:187

Testing script failed with code: 1

Does anyone know which could be the problem?

In the meantime, I'm going to continue working with 0.3.0 till I get time to debug this issue.

Thanks!
@garris
Copy link
Owner

garris commented Feb 9, 2015

Hi @dendril, thanks for filing this. The config files are slightly different from version 0.3.0 & 0.4.0 and this could cause the issue.

If you run gulp genConfig the app will write a default configuration file at the root of your project. (Please be careful, this will overwrite any config existing at that location.)

Then you can try running gulp reference and gulp test. It should work then. Please let me know if that fixes the issue.

Thanks! GS

@garris garris self-assigned this Feb 9, 2015
@garris garris added the question label Feb 9, 2015
@lewisnyman
Copy link
Contributor

Maybe we could add more useful error messages for people who are caught by
the upgrade?

On Monday, 9 February 2015, Garris [email protected] wrote:

Hi @dendril https://github.com/dendril, thanks for filing this. The
config files are slightly different from version 0.3.0 & 0.4.0 and this
could cause the issue.

If you run gulp genConfig the app will write a default configuration file
at the root of your project. (Please be careful, this will overwrite any
config existing at that location.)

Then you can try running gulp reference and gulp test. It should work
then. Please let me know if that fixes the issue.

Thanks! GS

—
Reply to this email directly or view it on GitHub
#34 (comment).

Lewis Nyman
+447753103690
lewisnyman.co.uk http://www.lewisnyman.co.uk
@lewisnyman http://twitter.com/lewisnyman

@garris
Copy link
Owner

garris commented Feb 9, 2015

Yes. Messaging would be the right way to go. Just a 'No paramName value found.' should do it.

@garris
Copy link
Owner

garris commented Feb 10, 2015

I just patched this in 0.4.1. Old config parameters are now mapped to the new ones internally. This is lowest friction for users. The old format is deprecated, but on reflection, I think we should go a few releases before breaking everyones tests.

Extra credit is to still add the warning on the console on detection of old configs.

Cheers GS

@garris garris closed this as completed Feb 10, 2015
@garris
Copy link
Owner

garris commented Feb 10, 2015

@dendril Please verify the fix if you get a minute. Regards. GS

@facundocabrera
Copy link
Author

@garris I was having 2 problems:

1- I'm building a docker image with this project, this means I'm installing everything in a minimal box, and phantomjs depends on libraries which must be present in the system before start using it.
2- The configuration file was slightly different because of the version change.

Thanks for you help!

@dgrebb dgrebb mentioned this issue Dec 15, 2023
Merged
garris pushed a commit that referenced this issue Dec 15, 2023
@dgrebb
Node 20: Docker, package.json dependency updates, README enhancements…
38543f4 
…, and general bugfixes and enhancements for developer experience. (#1523)

* style(remote): adjusts spacing/quotes for eslint rules (#34)

* feat(backstopjs): updates dev/dependencies to latest possible versions (#34)

* build(backstopjs): adds engines, type (commonjs), and bump package.json version (#34)

* build: adds 'docker-load' script for local testing (#34)

this loads the custom docker image, built with buildx, into local system container namespace. necessary when updating dockerfile without the option to publish to docker registry.

* fix: removes obsolete `genConfig` npm script (#34)

`genConfig` is now `makeConfig` and is ultimately used in `backstop init`. There is no need to test this separately, as it's part of the
overall flow of `init`, which is now used in npm's `integration-test` script, and passing.

* fix: removes obsolete 'echo' npm script

This was originally part of the `gulp` workflow, back in the `slimer` and `casper` days. https://github.com/garris/BackstopJS/blob/b00ab5bf358fcb3b77724ac4ef10b30e86b5188d/core/command/echo.js

* test: adds success, caution, and failure messaging to unit, integration, smoke, and sanity tests

This provides a final outcome message for all npm scripts for internal project testing. With tests that `exit 1`, a caution message is used, as opposed to a full-blown "FAIL".

* build: specifies npm@>=8 in package engines

also renames "docker-load" script "load-docker" to align with other script naming conventions

* build: updates and refactors README.md

* build(docker): updates Dockerfile with node:20-bullseye

* test: adds playwright smoke tests

* test: echo fail message if smoke tests succeed

* feat(docker): includes playwright and deps installation in Dockerfile

* test(backstop): updates caution message with advice to check logs
@dgrebb dgrebb mentioned this issue Dec 22, 2023
Merged
@chriswrightdesign chriswrightdesign mentioned this issue Feb 3, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@garris garris

Labels
question
Projects
None yet
Milestone
No milestone
3 participants
@facundocabrera @garris @lewisnyman