Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with dependency versioning #983

Closed
aw-davidson opened this issue Feb 12, 2019 · 3 comments
Closed

Issues with dependency versioning #983

aw-davidson opened this issue Feb 12, 2019 · 3 comments

Comments

@aw-davidson
Copy link
Contributor

I'm trying to use a specific version of chrome with backstop, but am unable to do so because of the ^ in front of puppeteer. I see @brendonbarreto made a fix for this in #960 but then it was reverted. Are there plans to include this fix in the future? I think it would be a good idea to bump backstop every time puppeteer is bumped.

@garris
Copy link
Owner

garris commented Feb 13, 2019

I had to back that change out because that commit broke the scrubber feature. I'm happy to reapply you want to pull that diff and troubleshoot/fix the issue.

@aw-davidson
Copy link
Contributor Author

@garris sounds good. How do I check the scrubber feature?

@garris
Copy link
Owner

garris commented Feb 13, 2019

Sure, Just run a test on something that will produce a diff -- then click on the diff in the web report. If the scrubber is grabbable/useable then everything is good. If it doesn't work -- then you'll need to figure out which dependency caused the issue.

Cheers.

aw-davidson pushed a commit to aw-davidson/BackstopJS that referenced this issue Feb 14, 2019
@garris garris closed this as completed in 9e4285c Feb 15, 2019
garris added a commit that referenced this issue Feb 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants