Feature/approve button #1150
Feature/approve button #1150
Conversation
1. Fix indentation and space. 2. Remove unused fs import 3. Fix no-negated-in-lhs
…nvolves state change
availabeStatus could be derived from tests. Do not need to list it in state and reducer for now.
| const REMOTE_HOST = 'http://127.0.0.1'; | ||
| const REMOTE_PORT = 3000; |
There was a problem hiding this comment.
There is an open issue in ember-backstop to make backstop run on a port other than the default port 3000. Will having this as a constant make it harder to implement that ?
There was a problem hiding this comment.
This is a great point. When Backstop opens a report (either internally or via user on cli) it runs openReport.js -- notice here is where the port is defined...
BackstopJS/core/command/openReport.js
Line 9 in 724f16e
So, we should be using your port bar there.
And it is probably just a matter of swapping that hard coded port 3000 with a dynamic one from the passed in config object.
AN ADDITIONAL THING TO NOTE: This also happens to be where we explicitly tell the report UI that it is in REMOTE mode. Some features, like Approve will only work in remote mode (i.e. when backstopRemote is running). I don't remember if the UI has a global variable to track this -- but it needs one. And the Approve option should not be shown unless we are in remote mode.
|
Can you please say how to add approve button? |
Approve a test
Display an error message when approving a test fails
