Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ability to read config settings from onBefore script. #994

Merged
merged 6 commits into from
Mar 11, 2019
Merged

Ability to read config settings from onBefore script. #994

merged 6 commits into from
Mar 11, 2019

Conversation

jprado
Copy link
Contributor

@jprado jprado commented Feb 22, 2019

No description provided.

@garris
Copy link
Owner

garris commented Feb 23, 2019

Would you please add to documentation?

@jprado
Copy link
Contributor Author

jprado commented Feb 28, 2019

Updated.

garris
garris reviewed Mar 11, 2019
View reviewed changes
Copy link
Owner

@garris garris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this already part of onReady script. If not we should probably add it.

@jprado
Copy link
Contributor Author

jprado commented Mar 11, 2019

Good call. Updated.

garris
garris approved these changes Mar 11, 2019
View reviewed changes
Copy link
Owner

@garris garris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Boom. Approved. Thanks!

@garris garris merged commit bbee6c0 into garris:master Mar 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garris garris garris approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jprado @garris