Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert expires_in value to numeric #30

Merged
merged 1 commit into from
Oct 21, 2023
Merged

Conversation

gathuku
Copy link
Owner

@gathuku gathuku commented Oct 21, 2023

expires_in somehow allowed passing string values but the feature was not documented . This will however throw errors from rails 7.1.

Convert the value to Numeric to work as expected.

The errors

/Users/gathuku/.asdf/installs/ruby/3.1.2/lib/ruby/gems/3.1.0/gems/activesupport-7.1.1/lib/active_support/cache.rb:866:in `merged_options': undefined method `negative?' for "3599":String (NoMethodError)

closed #29

@gathuku gathuku merged commit 9cb936e into master Oct 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

undefined method `negative?' for "3599":String
1 participant