Downgrade Protobuf from 4.x to 3.x #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: - grpc-java is not fully compatible with Protobuf 4; see: grpc/grpc-java#11015 - Protobuf 4 breaks our demo server due to an incompatibility between the generated code and what the grpc-java library expects. Modifications: - Downgrade to Protobuf 3 on all projects. - Prevent upgrade to Protobuf 4 in dependabot.yml (note: scala-steward doesn't seem to pick up Protobuf updates anyway, probably because it's not configured as a library dependency per se). Result: Stick to Protobuf 3 for now.
Motivation: We require Java 11 minimum
slandelle
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
grpc-java is not currently fully compatible with Protobuf 4; see: grpc/grpc-java#11015
In particular, protobuf 4 breaks our demo server due to an incompatibility between the generated code and what the grpc-java library expects.