-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[gatsby-plugin-feed] Api for creating multiple dynamic feeds based off of a query #12184
Comments
Hello @mikefowler and @secretfader I see you guys have contributed to |
While I love seeing people take an interest in RSS (and syndication feeds in general), I've largely stepped away from Gatsby development and no longer have a controlling interest in @DSchau has proposed a few changes to how options are parsed and validated in #12085, which may open the door to supporting new methods for ingesting configuration and creating feeds. Still, the general trend (at least among plugins in the core repo) seems to bend towards the most common use cases, expanding functionality carefully if needed. It's probably worth considering what it would take to write this feature once the PR covering option validation lands. But it could also be better addressed by a plugin you write to handle a specific use case. |
@secretfader couldn't have said it better myself. The work I'm doing in that PR does make it slightly easier to add new features (in a way that the user is at least aware if they're being used incorrectly, wrong options passed). @jsanchez034 However - this seems like it could lead to some fairly significant bloat in a plugin that is already sorta confusing to use. I don't ever want to discourage someone from contributing, because I completely understand the use case for the plugin you describe, but maybe this makes most sense as a fork or something that is maintained outside of the Gatsby repo? In some sense, maintaining a repository is about making sure you're focusing on the right things and balancing the right trade offs. Introducing features that may not be generally applicable (but valuable!) introduce a maintenance burden on maintainers. What do you think @jsanchez034? Want to make it clear that this is a discussion not a decision. Happy to be persuaded! |
Thanks for the feedback @DSchau and @secretfader! Yeah I think the use case might be too specific like you guys described. I will create a separate plugin for my use case. |
@jsanchez034 awesome - would you mind keeping us in the loop as to when you publish? We're also happy to provide any feedback along the way! |
Awesome will do 👍 Thanks for the support! |
@jsanchez034 Did you publish your plugin? I can't find it |
Hi! Never got around to making the plugin. I ended up not needing the multi feed feature |
Ok thank you for your feedback. |
Hi! Did you just dropped multifeed feature or did you just workaround a solution. Please could you let me know, I'm in the same scenario. |
Yeah ended dropping the multi-feed feature
…On Tue, Oct 6, 2020 at 8:45 AM Ernesto de la Cruz Guevara Ramírez < ***@***.***> wrote:
@jsanchez034 <https://github.com/jsanchez034> Did you publish your
plugin? I can't find it
Hi! Never got around to making the plugin. I ended up not needing the
multi feed feature
Hi! Did you just dropped multifeed feature or did you just workaround a
solution. Please could you let me know, I'm in the same scenario.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#12184 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAFZZ77P2Q3YHP4LTLULJ6DSJMGQFANCNFSM4G25BXXQ>
.
|
Summary
When creating rss feeds with
gatsby-plugin-feed
it would be great to have the ability to create multiple feeds from dynamic data coming from a single GraphQL query. In other words to create numerous feeds at build time where you wouldn't know up front ( without GraphQL query data ) how many you need.Basic example
Bellow I'm proposing adding a new config property to a feed object called
mapToFeedFiles
. From it the user would return an array of feed objects that would support all current feed properties minusserialize
and instead support a property calledserializedItems
which basically would be similar to whatserialize
property function normally would return.Motivation
The motivation behind this is say you have a blog with posts that each have a main category assigned to them. Furthermore the categories are created by content creators in your headless CMS system such a Contentful. Each category has its own page on your blog site listing the posts under that category and you want each page to have a rss feed. The above api addition would allow for creating a rss feed per category.
If given the ok with the above api from the maintainers of the plugin, I can implement the new feature as well. I just wanted some feedback on the proposal before creating a PR. Thanks for the consideration!
The text was updated successfully, but these errors were encountered: