Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update react-helmet syntax across project #1906

Closed
markmichon opened this issue Aug 24, 2017 · 1 comment
Closed

Update react-helmet syntax across project #1906

markmichon opened this issue Aug 24, 2017 · 1 comment

Comments

@markmichon
Copy link
Contributor

With react-helmet v5, the syntax was changed. This isn't a breaking issue, as it's all backwards compatible for now, but the change notes that the old props-based syntax will be deprecated in the future. Currently Gatsby uses the most recent version (5.1.3) in the core gatsby-plugin-react-helmet plugin.

The larger benefit is new user experience, as react-helmet docs don't include much info on the syntax used throughout Gatsby's docs. As far as I can tell it's only the examples and docs that use the syntax (maybe some starters too).

I'm happy to make the changes and put together a PR for this if it's something the maintainers think is useful.

@KyleAMathews
Copy link
Contributor

Sure! Would love a PR updating us to the latest and greatest. Thanks for offering!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants