-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update react-helmet syntax to new simplified API #1919
Update react-helmet syntax to new simplified API #1919
Conversation
Deploy preview ready! Built with commit bbd9dea |
Deploy preview ready! Built with commit bbd9dea |
Do you have an error output for |
@jbolda sure thing, it has to do with the query in the index layout.
The fix is pretty straightforward, changing the above query into:
Then adjusting some of the variable declarations in the file. I can put together a PR specifically for that, with the inclusion of the helmet changes. It looked like a good portion was still WIP so I didn't want to get in the way. |
It's... as finished as it can be pending #1895. This is issue fixed already in that PR. Might have been good to separate it into another PR though. I haven't and didn't plan to update react-helmet as part of that PR though. Whatever you think is best. I just wanted to make sure it wasn't something else I missed. |
Ah, I see. Makes sense. I'll leave it out of this PR and adjust down the road once it makes it's way into master. |
@jbolda |
Nice! Love the new syntax. Thanks for fixing things up! |
Hiya @markmichon! 👋 This is definitely late, but on behalf of the entire Gatsby community, I wanted to say thank you for being here. Gatsby is built by awesome people like you. Let us say “thanks” in two ways:
If you have questions, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’. Thanks again! 💪💜 |
Closes #1906. Converts most examples, as well as the gatsbyjs.org site source to use the new simplified api in
react-helmet
. One notable exception being theexamples/using-javascript-transforms
files, as the example fails to run and probably deserves it's own PR with some updates.