Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(gatsby): Update more dependencies to support graphql@14 #11512

Merged

Conversation

janicduplessis
Copy link
Contributor

@janicduplessis janicduplessis commented Feb 3, 2019

Description

I noticed a few peer dependencies warning since updating to graphql@14 (#11377), the goal is to fix those by updating some dependencies to the latest version that supports graphql@14. Nothing is broken because of this but this will remove some peer dep warnings.

Verified the changelog of each updated lib to make sure there were no breaking changes affecting us.

Related Issues

Follow up to PR #11377

@RomanHotsiy
Copy link
Contributor

Looks like broken CI has nothing to do to the changes.

@janicduplessis could you try rebasing this PR?

@janicduplessis
Copy link
Contributor Author

@RomanGotsiy Rebased, tests are now passing

@RomanHotsiy
Copy link
Contributor

cc @stefanprobst

Copy link
Contributor

@sidharthachatterjee sidharthachatterjee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @janicduplessis 👍

@sidharthachatterjee sidharthachatterjee changed the title Update more dependencies to support graphql@14 chore(gatsby): Update more dependencies to support graphql@14 Mar 8, 2019
@sidharthachatterjee sidharthachatterjee merged commit 3239956 into gatsbyjs:master Mar 8, 2019
@sidharthachatterjee
Copy link
Contributor

Published in

@stefanprobst
Copy link
Contributor

@janicduplessis @RomanGotsiy Unfortunately this had to be reverted because the updated graphql-tools does not seem to serialize enums correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants