Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(gatsby-plugin-emotion): allow newer versions of babel-preset-css-prop #11922

Merged
merged 1 commit into from
Feb 20, 2019
Merged

chore(gatsby-plugin-emotion): allow newer versions of babel-preset-css-prop #11922

merged 1 commit into from
Feb 20, 2019

Conversation

17cupsofcoffee
Copy link
Contributor

Description

This PR updates the package.json of gatsby-plugin-emotion to allow newer versions of babel-preset-css-prop to be used.

Related Issues

This fixes #11915, as newer versions of babel-preset-css-prop have resolved that issue.

@17cupsofcoffee
Copy link
Contributor Author

Not sure why one of the E2E tests is failing - it doesn't depend on gatsby-plugin-emotion, so I think it's just CI being weird...

@wKovacs64
Copy link
Contributor

Cypress on Circle is dodgy, I just re-ran it and it passed. Of course, now it's failing for another unrelated reason, but... oh well. ¯\_(ツ)_/¯

Copy link
Contributor

@wKovacs64 wKovacs64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DSchau
Copy link
Contributor

DSchau commented Feb 20, 2019

@wKovacs64 the starters:validate task is actually failing (and has been for a few days now). Unrelated to this PR, though.

Follow along #11895 for more info

@wKovacs64
Copy link
Contributor

wKovacs64 commented Feb 20, 2019

@DSchau Yep, I'm aware. 🙂 (Edit: that wasn't what was failing when @17cupsofcoffee mentioned it, it was e2e_tests_path-prefix.)

@DSchau DSchau changed the title chore(gatsby-plugin-emotion): Allow newer versions of babel-preset-css-prop chore(gatsby-plugin-emotion): allow newer versions of babel-preset-css-prop Feb 20, 2019
@DSchau DSchau merged commit ffaf297 into gatsbyjs:master Feb 20, 2019
@gatsbot
Copy link

gatsbot bot commented Feb 20, 2019

Holy buckets, @17cupsofcoffee — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. (Currently we’ve got a couple t-shirts available, plus some socks that are really razzing our berries right now.)
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

@DSchau
Copy link
Contributor

DSchau commented Feb 20, 2019

@wKovacs64 whoops - I didn't know they were failing because the restart fixed it (so they were all green, besides the starters:validate).

I'll take another look at that tomorrow--that seems to be a pesky reoccurring one.

Thanks for clarifying!

@DSchau
Copy link
Contributor

DSchau commented Feb 20, 2019

Successfully published:
 - [email protected]

🎉 Thanks so much for this PR!

@wKovacs64
Copy link
Contributor

@DSchau All good, the timing definitely muddied that scenario. :)

@17cupsofcoffee 17cupsofcoffee deleted the patch-1 branch February 21, 2019 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gatsby-plugin-emotion throws an error if a component only contains fragment JSX
3 participants