-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(gatsby-plugin-emotion): allow newer versions of babel-preset-css-prop #11922
Conversation
Not sure why one of the E2E tests is failing - it doesn't depend on gatsby-plugin-emotion, so I think it's just CI being weird... |
Cypress on Circle is dodgy, I just re-ran it and it passed. Of course, now it's failing for another unrelated reason, but... oh well. ¯\_(ツ)_/¯ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@wKovacs64 the starters:validate task is actually failing (and has been for a few days now). Unrelated to this PR, though. Follow along #11895 for more info |
@DSchau Yep, I'm aware. 🙂 (Edit: that wasn't what was failing when @17cupsofcoffee mentioned it, it was |
Holy buckets, @17cupsofcoffee — we just merged your PR to Gatsby! 💪💜 Gatsby is built by awesome people like you. Let us say “thanks” in two ways:
If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’. Thanks again! |
@wKovacs64 whoops - I didn't know they were failing because the restart fixed it (so they were all green, besides the starters:validate). I'll take another look at that tomorrow--that seems to be a pesky reoccurring one. Thanks for clarifying! |
🎉 Thanks so much for this PR! |
@DSchau All good, the timing definitely muddied that scenario. :) |
Description
This PR updates the
package.json
of gatsby-plugin-emotion to allow newer versions of babel-preset-css-prop to be used.Related Issues
This fixes #11915, as newer versions of babel-preset-css-prop have resolved that issue.