Gatsby copy linked files, video tag support, a tag support and option to ignore default ignored file types #1571
Conversation
|
video and a tag support coming soon. |
|
Deploy preview ready! Built with commit 2421ddc |
|
Deploy preview failed. Built with commit 76bbfc3f34cb85911d7c344a9537214efb3632a3 https://app.netlify.com/sites/gatsbyjs/deploys/5978b2550752d0375d5f691c |
|
Deploy preview ready! Built with commit adee534 |
chiedo
force-pushed
the
gatsby-copy-linked-files/more-features
branch
from
14a94c4 to
44707dc
Compare
|
I think this is officially ready. :) All features I wanted to add are now there. |
chiedo
changed the title
| { | ||
| resolve: 'gatsby-remark-copy-linked-files', | ||
| options: { | ||
| ignoreFileExtensions: ['png', 'jpg', 'jpeg', 'bmp', 'tiff'], |
There was a problem hiding this comment.
Could you add a comment here saying this is the default options?
There was a problem hiding this comment.
So you don't need to add it.
Or even better, show the simple default way to add the plugin to gatsby-config and what to do if you want to copy images over (e.g. an empty ignoreFileExtensions.
There was a problem hiding this comment.
Let me know what you think about the changes I just made.
|
Deploy preview failed. Built with commit a37d48ac527a8fb669cb078578e547c6df0f74ba https://app.netlify.com/sites/using-styled-components/deploys/5977c3e3424ef2111748eabf |
|
Deploy preview failed. Built with commit 12a333472c97b480824fa36b3c720c274faf85c0 https://app.netlify.com/sites/using-remark/deploys/5977994b6f4c50758d7ec9b7 |
|
Deploy preview failed. Built with commit adee534 https://app.netlify.com/sites/using-glamor/deploys/59dfebeca6188f3de3a76b0a |
|
Deploy preview failed. Built with commit 12a333472c97b480824fa36b3c720c274faf85c0 https://app.netlify.com/sites/image-processing/deploys/5977994b6f4c50758d7ec9a8 |
|
Deploy preview failed. Built with commit 12a333472c97b480824fa36b3c720c274faf85c0 https://app.netlify.com/sites/using-contentful/deploys/5977994b6f4c50758d7ec9b2 |
|
Deploy preview failed. Built with commit 12a333472c97b480824fa36b3c720c274faf85c0 https://app.netlify.com/sites/using-postcss-sass/deploys/597799496f4c50758d7ec9a1 |
|
Getting a bunch of errors now when building gatsbyjs.org |
|
I'll look into it! Worked on all my sites. I'm assuming the deploy preview will tell me when I got it right? |
|
Where can I find the gatsbyjs.org code base so I can do some test builds and debug? Grep and find turned up nothing. Sorry if I'm missing something obvious. |
|
It's in the |
chiedo
force-pushed
the
gatsby-copy-linked-files/more-features
branch
2 times, most recently
from
5efa155 to
76bbfc3
Compare
|
I haven't had any luck. If anyone else sees this, feel free to dig in. This plugin works perfectly on my sites. I can't figure out why it isn't working on gatsby.org. At this point the only errors I'm getting are gatsby-remark-images errors which doesn't make sense to me seeing as I've changed nothing in those files in this pull request. It seems like there's some sort of connection between the two plugins even when this plugin ignores the file types that the remark-images plugin works on. Not sure. I'm using this in production as a local plugin on my sites but can't figure out why this is breaking gatsby.org. Spent about 3 hours digging into it with no progress. Open to answer any questions for anyone that sees this and has them |
|
If you remove this plugin does Gatsbyjs build? If you change the order of plugins does that change anything? |
|
The issues remain if I comment out this plugin. The exact same error (all gatsby-remark-images errors after adding some try catches) still displays. The issues go away if I comment out gatsby-remark-images. That's why I'm confused. I haven't changed anything in remark-images as far as this branch is concerned... lol It appears to be a gatsby-remark-images bug but I don't understand how that makes sense. |
|
Hmmm that doesn't make sense. Can you reproduce these errors if you switch to master? |
|
First thing I tried this morning. Master worked fine. Just tested again. Master is still error free. How are you testing plugins by the way that aren't public yet? I'm manually overwriting node_modules to test how they would function from npm. I'm using the plugins directory fore my projects while waiting for pull requests to be merged but while testing before doing a pull request, is there an easier way than copying to and clearing node_modules? |
|
Update to master then? On developing, gatsby-dev-cli https://www.gatsbyjs.org/docs/how-to-contribute/ |
Thanks, I'll have to read that section more closely!
Same issue as soon as I add my new version of the gatsby-remark-copy-linked-files plugin. As soon as I change that, gatsby-remark-images starts having issues. |
|
Have you tried changing the order of the two plugins? If there's some sort of interaction between the two, changing the order probably would affect that. |
|
Yeah, no difference. I've tried a lot and I'm honestly quite confused. I don't even see how interaction could occur. My code isn't doing anything that should be affected by any interaction. It's ultimately just reading files and then copying data. |
Added - ability to ignore specific file types and override defaults - Ability to copy all image types if desired - parsing of html a tags - parsing of html video tags
chiedo
force-pushed
the
gatsby-copy-linked-files/more-features
branch
from
9c25e46 to
1ffe64c
Compare
|
Yeah!!! Tests are passing and gatsbyjs.org is building :-D Merging this overly old PR now! |
|
YAY!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! :) |
|
|
||
| - <img /> | ||
| - <video /> | ||
| - <a /> |
There was a problem hiding this comment.
These are not wrapped in code tags (<img/>) and are attempting to render on https://www.gatsbyjs.org/packages/gatsby-remark-copy-linked-files/
| @@ -3,9 +3,19 @@ const isRelativeUrl = require(`is-relative-url`) | |||
| const fsExtra = require(`fs-extra`) | |||
| const path = require(`path`) | |||
| const _ = require(`lodash`) | |||
| const $ = require(`cheerio`) | |||
| const cheerio = require(`cheerio`) | |||
| const sizeOf = require(`image-size`) | |||
There was a problem hiding this comment.
This new dependency image-size was added yet not included in the package.json which causes this plugin to fail for me
|
Hey guys, found two issues that I just ran into. I'll submit a PR tonight or tomorrow. |
* Add new dependency This dependency was starting to be used from #1571 but it was never added as a dependency. * Wrap html tags as code
I added the ability to copy linked images in HTML nodes and also the ability to override which file types are ignored so you can now copy png and svg files if you would like, etc.