fix(gatsby-plugin-offline): skip prefetching all resources #16691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wardpeet
reviewed
Aug 21, 2019
wardpeet
added
the
status: awaiting author response
|
Hi @rexxars 👋 Did you find time to address Ward's comments? Would be awesome to have this merged in! Thanks a lot :) |
|
Will have a look later today! |
wardpeet
approved these changes
Sep 23, 2019
|
Thanks for fixing, I kind of forgot about this 😊 |
wardpeet
removed
the
status: awaiting author response
|
I'm going to merge this one, if we need to rollback, we'll rollback :) |
wardpeet
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If you have a plugin which uses the
setHeadComponentsAPI to add link-tags with apreconnectrel, the offline plugin will schedule it to be prefetched. This leads to the situation where instead of simply opening a connection to the specified host, it instead triggers a GET-request.I'm not 100% clear on what should happen if you have
prefetchorprerenderlinks, but I feel like skipping them is probably a better option that to add another prefetch for them? Would love to hear your thoughts on this, though.Related Issues
Fixes #15883