perf(gatsby): more efficient parent-child check through arrays #22126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pvdz
added
the
bot: merge on green
|
Seems to save ~30s from the 340s total runtime on the ifsc benchmark (from 343s to 314s), 20s of that is bootstrap: https://gist.github.com/pvdz/b4eeecb062ed28a48a6d7cc16b644de9 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces a
_.uniqwith a.includeswhich is calledNtimes, once for each node, while the array of nodes is building up (or on the full set even?). The only reason, I think, is to make sure the newly inserted child does not already exist in the array of children. Theincludessimply does a subset of thingsuniqdoes.Another change is that a new array is no longer created;
parent.childrenremains the same array reference after this step now.Addresses a problem surfaced by @tsriram in #21447
Drops the
source and transformstep by about 33% at scale. This step in a benchmark of 100k pages drops from 30s to 20s, a 150k pages bench drops from 45s to 30s.This is the long hanging fruit. There's still a lot of room for improvement.