Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unused variable and wrong propTypes #22426

Merged
merged 3 commits into from
Mar 20, 2020
Merged

Unused variable and wrong propTypes #22426

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
286ec80
delete unused variable
soobing Mar 20, 2020
a0331e2
change type string to number
soobing Mar 20, 2020
b2f5736
Merge remote-tracking branch 'upstream/master' into seo-tutorial
Mar 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions docs/tutorial/seo-and-social-sharing-cards-tutorial/index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,8 +269,8 @@ SEO.propTypes = {
// highlight-start
image: PropTypes.shape({
src: PropTypes.string.isRequired,
height: PropTypes.string.isRequired,
width: PropTypes.string.isRequired,
height: PropTypes.number.isRequired,
width: PropTypes.number.isRequired,
}),
// highlight-end
}
Expand Down Expand Up @@ -424,8 +424,8 @@ SEO.propTypes = {
title: PropTypes.string.isRequired,
image: PropTypes.shape({
src: PropTypes.string.isRequired,
height: PropTypes.string.isRequired,
width: PropTypes.string.isRequired,
height: PropTypes.number.isRequired,
width: PropTypes.number.isRequired,
}),
// highlight-next-line
pathname: PropTypes.string,
Expand Down Expand Up @@ -511,7 +511,6 @@ class BlogPostTemplate extends React.Component {
render() {
const post = this.props.data.markdownRemark
const siteTitle = this.props.data.site.siteMetadata.title
const { previous, next } = this.props.pageContext
const image = post.frontmatter.image
? post.frontmatter.image.childImageSharp.resize
: null // highlight-line
Expand Down