-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix source medium Plugin #2515
Fix source medium Plugin #2515
Conversation
- gatsby-node.js updated according to new medium api.
Deploy preview failed. Built with commit cc16ae4 https://app.netlify.com/sites/using-glamor/deploys/59e77f1c0b79b75fbcd60fb2 |
Deploy preview ready! Built with commit 014c8e6 |
Thanks for the PR! I'm a bit confused though. How is the plugin outdated? Medium changed their API? Or are you adding support for querying users? |
Hey Kyle,
while current code is looking for |
Hey, Kyle better hold PR a bit. Question is; How about Gatsby |
The plugin acts exactly the same for develop and build. We might add a publish command at some point but it's not a high priority right now. Easy enough generally to just use the CLIs provided by different hosting providers. |
@KyleAMathews understood, well no need then. |
@deniaz @mfeltscher could you review this PR before I merge it? |
Hey there, From what I can see that API hasn't changed, but @Necmttn doesn't post to a collection on Medium. If you take my user (https://medium.com/@deniaz/latest?format=json) Also the links are removed (https://github.com/gatsbyjs/gatsby/pull/2515/files#diff-914dccf08660c2fd85676d5e5412464cL54) which were explicitly asked for by @KyleAMathews ;) The reason why we didn't use the official API here because it does not support reading posts, just publishing. From my point of view the code should check whether |
Hey :) |
The plugin was outdated. it's working now.