fix(gatsby-cli,gatsby-recipes): only run recipes when admin is enabled #26671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
vladar
removed
the
status: triage needed
wardpeet
added
status: needs core review
laurieontech
previously approved these changes
Aug 31, 2020
wardpeet
force-pushed
the
fix/recipes-kill
branch
from
0d4105b to
8c17c45
Compare
wardpeet
force-pushed
the
fix/recipes-kill
branch
from
8c17c45 to
648a05d
Compare
wardpeet
force-pushed
the
fix/recipes-kill
branch
from
648a05d to
41ec8e2
Compare
LekoArts
added
topic: DX
|
Closing due to #34094 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When closing develop sometimes the recipes GraphQL wouldn't exit and stay in limbo. This uses execa to make sure we kill the process. I also added an env var so it only loads with admin.