fix(gatsby-plugin-sharp): PathPrefix isn't being passed/set for GatsbyImage #28845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
laurieontech
added
topic: media
laurieontech
commented
Jan 4, 2021
added 3 commits
January 4, 2021 16:52
ascorbic
reviewed
Jan 5, 2021
ascorbic
reviewed
Jan 5, 2021
ascorbic
reviewed
Jan 5, 2021
vladar
added
bot: merge on green
gatsbybot
pushed a commit
that referenced
this pull request
Jan 13, 2021
…yImage (#28845) (#28991) * fix for path-prefix in GatsbyImage * add e2e test for path prefix cases * update tests * forgot to save * refactor * add curlys (cherry picked from commit 5874414) Co-authored-by: LB <[email protected]>
|
Published in |
This was referenced Mar 9, 2021
This was referenced Mar 14, 2021
pragmaticpat
pushed a commit
to pragmaticpat/gatsby
that referenced
this pull request
Apr 28, 2022
…yImage (gatsbyjs#28845) * fix for path-prefix in GatsbyImage * add e2e test for path prefix cases * update tests * forgot to save * refactor * add curlys
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is working fine for StaticImage, but GatsbyImage was passing pathPrefix from the wrong place in the resolver and not including it in srcSet for webp and avif images.
[ch20512]