chore: Update image API to remove maxWidth/maxHeight #28985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
laurieontech
added
topic: media
|
The types in |
ascorbic
force-pushed
the
image-update-keys
branch
from
b36c8c6 to
201128a
Compare
ascorbic
previously approved these changes
Jan 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Going forward, fixed/constrained images will take width and height as parameters, rather than the previous option of maxWidth/maxHeight for fluid and constrained images.
Open question: Right now fluid can take width and height. At what level do we want to warn the user to use breakpoints instead? Or do we want to cover that in the forthcoming breakpoints PR?
(Note that the failing tests are based on the plugin helpers, I'm missing something there)
READMEs outside of gatsby-plugin-image are also not updated as versioning those is not clear. Should determine that before merging this PR.
[ch22681]