docs(gatsby-plugin-image): Initial migration guide #29036

laurieontech · 2021-01-14T20:35:49Z

This is a draft of the migration guide.

[ch22957]

meganesu

This is definitely on the right track! 🙌 I think all the right pieces of information are here, but there might be a better way to group them. The way I'm chunking this content in my head looks something like:

Introduction (there's a new plugin!)
What changed?
- New Syntax
- API changes
- Unsupported usage
How to migrate?
- Install
- Codemod instructions
  - Codemod assumptions
- Recommended changes (I got the sense that these were additional changes needed on top of the codemod?)

What do you think?

docs/docs/reference/release-notes/image-migration-guide.md

ascorbic

Just a few comments. I've done them as change suggestions, but that's just as it's easier. I'm not expecting you to use my words

docs/docs/reference/release-notes/image-migration-guide.md

Co-authored-by: Matt Kane <[email protected]>

docs/docs/reference/release-notes/image-migration-guide.md

Co-authored-by: Matt Kane <[email protected]>

ascorbic

@meganesu should check too, but this looks great to me.

meganesu

This looks awesome! Left a bunch of copy edits, but after those this looks ready to me! Great job 🎉 ✨

docs/docs/reference/release-notes/image-migration-guide.md

Co-authored-by: Megan Sullivan <[email protected]>

docs/docs/reference/release-notes/image-migration-guide.md

Co-authored-by: Megan Sullivan <[email protected]>

docs/docs/reference/release-notes/image-migration-guide.md

Co-authored-by: Matt Kane <[email protected]>

initial migration guide

b2a2cd6

gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jan 14, 2021

meganesu reviewed Jan 15, 2021

View reviewed changes

review notes

fc11bd7

vladar added type: documentation An issue or pull request for improving or updating Gatsby's documentation and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Jan 15, 2021

ascorbic mentioned this pull request Jan 18, 2021

docs(gatsby-plugin-image): Update readme #29076

Merged

ascorbic reviewed Jan 21, 2021

View reviewed changes

LB and others added 9 commits January 21, 2021 08:41

Update docs/docs/reference/release-notes/image-migration-guide.md

0bc2213

Co-authored-by: Matt Kane <[email protected]>

Update docs/docs/reference/release-notes/image-migration-guide.md

e1440e3

Co-authored-by: Matt Kane <[email protected]>

Update docs/docs/reference/release-notes/image-migration-guide.md

e6cb136

Co-authored-by: Matt Kane <[email protected]>

Update docs/docs/reference/release-notes/image-migration-guide.md

2b3b385

Co-authored-by: Matt Kane <[email protected]>

Update docs/docs/reference/release-notes/image-migration-guide.md

c353db4

Co-authored-by: Matt Kane <[email protected]>

Update docs/docs/reference/release-notes/image-migration-guide.md

53477aa

Co-authored-by: Matt Kane <[email protected]>

Update docs/docs/reference/release-notes/image-migration-guide.md

a9eb2b5

Co-authored-by: Matt Kane <[email protected]>

Update docs/docs/reference/release-notes/image-migration-guide.md

0cf7a0f

Co-authored-by: Matt Kane <[email protected]>

reword per matt's review

da30f42

ascorbic reviewed Jan 21, 2021

View reviewed changes

docs/docs/reference/release-notes/image-migration-guide.md Outdated Show resolved Hide resolved

Update docs/docs/reference/release-notes/image-migration-guide.md

4775321

Co-authored-by: Matt Kane <[email protected]>

laurieontech marked this pull request as ready for review January 21, 2021 17:35

ascorbic previously approved these changes Jan 22, 2021

View reviewed changes

meganesu reviewed Jan 22, 2021

View reviewed changes

Update docs/docs/reference/release-notes/image-migration-guide.md

c1a8971

Co-authored-by: Megan Sullivan <[email protected]>

laurieontech dismissed ascorbic’s stale review via c1a8971 January 22, 2021 20:23

LB and others added 6 commits January 22, 2021 15:23

Update docs/docs/reference/release-notes/image-migration-guide.md

db3365b

Co-authored-by: Megan Sullivan <[email protected]>

Update docs/docs/reference/release-notes/image-migration-guide.md

66d6d9a

Co-authored-by: Megan Sullivan <[email protected]>

Update docs/docs/reference/release-notes/image-migration-guide.md

50004ab

Co-authored-by: Megan Sullivan <[email protected]>

Update docs/docs/reference/release-notes/image-migration-guide.md

36145cf

Co-authored-by: Megan Sullivan <[email protected]>

Update docs/docs/reference/release-notes/image-migration-guide.md

9228736

Co-authored-by: Megan Sullivan <[email protected]>

Update docs/docs/reference/release-notes/image-migration-guide.md

0eb9b51

Co-authored-by: Megan Sullivan <[email protected]>

LB and others added 6 commits January 22, 2021 15:32

Update docs/docs/reference/release-notes/image-migration-guide.md

7677c58

Co-authored-by: Megan Sullivan <[email protected]>

Update docs/docs/reference/release-notes/image-migration-guide.md

b53f834

Co-authored-by: Megan Sullivan <[email protected]>

Update docs/docs/reference/release-notes/image-migration-guide.md

25204e9

Co-authored-by: Megan Sullivan <[email protected]>

Update docs/docs/reference/release-notes/image-migration-guide.md

3b3c3b1

Co-authored-by: Megan Sullivan <[email protected]>

Update docs/docs/reference/release-notes/image-migration-guide.md

396e9dc

Co-authored-by: Megan Sullivan <[email protected]>

Update docs/docs/reference/release-notes/image-migration-guide.md

6f563e4

Co-authored-by: Megan Sullivan <[email protected]>

laurieontech commented Jan 22, 2021

View reviewed changes

docs/docs/reference/release-notes/image-migration-guide.md Outdated Show resolved Hide resolved

LB and others added 7 commits January 22, 2021 15:35

Update docs/docs/reference/release-notes/image-migration-guide.md

398951f

Update docs/docs/reference/release-notes/image-migration-guide.md

0b64d9a

Co-authored-by: Megan Sullivan <[email protected]>

Update docs/docs/reference/release-notes/image-migration-guide.md

e98ab26

Co-authored-by: Megan Sullivan <[email protected]>

Update docs/docs/reference/release-notes/image-migration-guide.md

7cbf5a2

Co-authored-by: Megan Sullivan <[email protected]>

Update docs/docs/reference/release-notes/image-migration-guide.md

ee5c423

Co-authored-by: Megan Sullivan <[email protected]>

Update docs/docs/reference/release-notes/image-migration-guide.md

c656c04

Co-authored-by: Megan Sullivan <[email protected]>

not perfect but it'll work

dfa3d22

laurieontech added the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label Jan 22, 2021

ascorbic reviewed Jan 23, 2021

View reviewed changes

docs/docs/reference/release-notes/image-migration-guide.md Outdated Show resolved Hide resolved

ascorbic reviewed Jan 23, 2021

View reviewed changes

docs/docs/reference/release-notes/image-migration-guide.md Outdated Show resolved Hide resolved

ascorbic reviewed Jan 23, 2021

View reviewed changes

docs/docs/reference/release-notes/image-migration-guide.md Outdated Show resolved Hide resolved

ascorbic reviewed Jan 23, 2021

View reviewed changes

docs/docs/reference/release-notes/image-migration-guide.md Outdated Show resolved Hide resolved

ascorbic reviewed Jan 23, 2021

View reviewed changes

docs/docs/reference/release-notes/image-migration-guide.md Outdated Show resolved Hide resolved

ascorbic reviewed Jan 23, 2021

View reviewed changes

docs/docs/reference/release-notes/image-migration-guide.md Outdated Show resolved Hide resolved

LB and others added 7 commits January 25, 2021 08:40

Update docs/docs/reference/release-notes/image-migration-guide.md

8427777

Co-authored-by: Matt Kane <[email protected]>

Update docs/docs/reference/release-notes/image-migration-guide.md

e90efc9

Co-authored-by: Matt Kane <[email protected]>

Update docs/docs/reference/release-notes/image-migration-guide.md

8f043d0

Co-authored-by: Matt Kane <[email protected]>

Update docs/docs/reference/release-notes/image-migration-guide.md

b470378

Co-authored-by: Matt Kane <[email protected]>

Update docs/docs/reference/release-notes/image-migration-guide.md

fe21c99

Co-authored-by: Matt Kane <[email protected]>

Update docs/docs/reference/release-notes/image-migration-guide.md

3e8c7cc

Co-authored-by: Matt Kane <[email protected]>

Merge branch 'master' into image-migration-guide

7986572

laurieontech merged commit f00b929 into master Jan 25, 2021

laurieontech deleted the image-migration-guide branch January 25, 2021 19:18

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

docs(gatsby-plugin-image): Initial migration guide #29036

docs(gatsby-plugin-image): Initial migration guide #29036

laurieontech commented Jan 14, 2021

meganesu left a comment

ascorbic left a comment

ascorbic left a comment

meganesu left a comment

docs(gatsby-plugin-image): Initial migration guide #29036

docs(gatsby-plugin-image): Initial migration guide #29036

Conversation

laurieontech commented Jan 14, 2021

meganesu left a comment

Choose a reason for hiding this comment

ascorbic left a comment

Choose a reason for hiding this comment

ascorbic left a comment

Choose a reason for hiding this comment

meganesu left a comment

Choose a reason for hiding this comment