Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): Update sourcing-from-prismic #29237

Merged
merged 2 commits into from
May 6, 2021
Merged

chore(docs): Update sourcing-from-prismic #29237

merged 2 commits into from
May 6, 2021

Conversation

pvpg
Copy link
Contributor

@pvpg pvpg commented Jan 27, 2021

Hello Gatsby team, I'm opening a new PR for this Gatsby and Prismic page.

  1. I added links to our new documentation.
  2. Some minor changes to match the correct plugin configuration
  3. Minor change to the gatsby-node query to generate the pages using the post.url value from the query.
  4. And, a validation before saving the query responses. e.g., if (!data) return null

Let me know if you have any comments.
Thanks

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jan 27, 2021
@ascorbic ascorbic added status: needs docs review Pull request related to documentation waiting for review and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Jan 28, 2021
@LekoArts LekoArts changed the title Update sourcing-from-prismic.md chore(docs): Update sourcing-from-prismic May 6, 2021
@LekoArts LekoArts merged commit 3ecc9d8 into gatsbyjs:master May 6, 2021
axe312ger pushed a commit that referenced this pull request May 20, 2021
Co-authored-by: Paulina Gavilán <[email protected]>
Co-authored-by: gatsbybot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: needs docs review Pull request related to documentation waiting for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants