feat(gatsby): Remove old touchNode signature #29245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
LekoArts
added
topic: internal
topic: plugins
gillkyle
previously approved these changes
Feb 8, 2021
Co-authored-by: Kyle Gill <[email protected]>
|
@TylerBarnes I also had to update the WordPress plugin (will do the same in #29205) |
|
@LekoArts does this depend on a newer version of Gatsby? I haven't PR'd over the tests from the WP experimental repo yet so I'm a bit nervous to make changes to it. |
|
@TylerBarnes The change is made only here in this PR, so how about you merging your tests, I rebase onto master and we'll see if they work? |
wardpeet
changed the title
This reverts commit 2e4cc3a.
|
@TylerBarnes To get myself unblocked and you not urged to merge your tests ASAP I reverted the WordPress changes :) The current state is now using deprecated APIs then, but it still works. |
wardpeet
reviewed
Feb 10, 2021
wardpeet
approved these changes
Feb 10, 2021
benabel
added a commit
to gatsby-contrib/gatsby-plugin-elasticlunr-search
that referenced
this pull request
Mar 15, 2021
see: ttps://github.com/gatsbyjs/gatsby/pull/29245/files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Similarly to #29205 this removes an old arg signature, namely calling
touchNodewith a string (the id). This PR also adds a new deprecation so that in the futuretouchNodewill be called likecreateNodeanddeleteNode-- withtouchNode(node).Documentation
The docs (source plugin guide) are updated.
Related Issues
[ch23714]