fix(gatsby): Fix hot reloading for Safari #29960
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
LekoArts
added
topic: hot reloading
and removed
status: triage needed
LekoArts
changed the title
LekoArts
added
topic: DX
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #29952
It fixes the case for page queries, but at the moment it doesn't fix the issue that other updates (e.g. updating the React component's content itself) triggers an update.
For some reason only on Safari it doesn't find it:
However, adding the timestamp at least doesn't show the error overlay anymore. More to investigate to make real hot reloading work everywhere for Safari.
Related Issues
vuejs/vue-cli#1132
In commits 33dad39, 52dbdf8, and 0909bc8 of Vue CLI some things were tried, but they reverted them.
[ch26278]