fix(contentful): Add restricted content model names #30234
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
LekoArts
changed the title
LekoArts
added
topic: source-contentful
|
Thank you!! But I think this won't work. Did you try it out? |
axe312ger
added
the
status: needs core review
axe312ger
approved these changes
Mar 16, 2021
axe312ger
requested changes
Mar 16, 2021
| @@ -22,6 +22,8 @@ const restrictedNodeFields = [ | |||
| `id`, | |||
| `internal`, | |||
| `parent`, | |||
| `Entity`, | |||
| `Reference`, | |||
There was a problem hiding this comment.
This restricts field names, but we need to restrict Content Type names
There was a problem hiding this comment.
I was analyzing the code, but I could not figure out how to restrict the Content Type names. Could you give a hint?
|
My PR at #30715 should address this now properly :) |
|
Closing in favor of #30715 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds 2 restricted model names to
restrictedNodeFieldsarray so that when one uses those 2 model names, the error notifies the developer about it. Those 2 model names areReferenceandEntity. The related issue explains why those 2 names cannot be used.Related issues
Fixes #30089