Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gatsby-remark-images): GATSBY_EMPTY_ALT figcaption generation #30468

Merged
merged 2 commits into from
Oct 30, 2021

Conversation

nategiraudeau
Copy link
Contributor

Description

#30285

Documentation

Updated README.

Related Issues

Fixes #30285.

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Mar 25, 2021
ronalde
ronalde previously approved these changes Mar 26, 2021
Copy link

@ronalde ronalde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@vladar vladar added topic: remark/mdx Related to Markdown, remark & MDX ecosystem and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Mar 26, 2021
@nategiraudeau nategiraudeau reopened this Aug 11, 2021
@nategiraudeau
Copy link
Contributor Author

@vladar I finally fixed the linter problem.

@ronalde
Copy link

ronalde commented Oct 16, 2021

Still no luck @nategiraudeau?

@nategiraudeau
Copy link
Contributor Author

The tests seem to all be passing. Just waiting for someone to review.

@nategiraudeau nategiraudeau requested a review from vladar October 18, 2021 15:30
@wardpeet wardpeet changed the title fixed GATSBY_EMPTY_ALT figcaption generation fix(gatsby-remark-images): GATSBY_EMPTY_ALT figcaption generation Oct 30, 2021
@wardpeet wardpeet merged commit 1a73b01 into gatsbyjs:master Oct 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: remark/mdx Related to Markdown, remark & MDX ecosystem
Projects
None yet
5 participants