Use IntersectionObserver when polyfilled after gatsby-image first load #3056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview ready! Built with commit 2fce7b0 |
|
Deploy preview ready! Built with commit 2fce7b0 |
|
Cool! Yeah, lazy-loading the polyfill dynamically is the right call for most sites so this is necessary. |
|
It'd be nice to add the same PR for gatsby-link if you have time gatsby/packages/gatsby-link/src/index.js Line 30 in 59a5bbe |
|
Thanks! From what I can tell, gatsby-link is already checking for IntersectionObserver support upon component instantiation, so I think it's all set there! |
This was referenced Sep 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scenario:
If a browser lacks
IntersectionObserversupport, and later becomes polyfilled with support, gatsby-image would throw the errorTypeError: undefined is not an object (evaluating 'io.observe').Explanation:
The
<Image>component checks for IntersectionObserver support upon instantiation, butiowould only attempt to be defined once, upon initial load of gatsby-image. This resulted in an attempt to use the undefinediovariable.This change attempts to initialize
ioif not already defined whenever it is requested.