Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gatsby-source-wordpress): invalidate less queries during previews #30770

Merged
merged 1 commit into from
Apr 13, 2021

Conversation

TylerBarnes
Copy link
Contributor

@TylerBarnes TylerBarnes commented Apr 8, 2021

For Preview, revisions of a node type can have data that updates unnecessarily
This PR fixes that. The result being that less queries are invalidated in Gatsby. For example if you have a query where you're getting the latest published post using the date field, that data should be static but each preview updates the date field on the node being previewed (because the revision has a new date). So if we prevent the fields in this PR from changing, this will be less problematic.

This makes preview for GatsbyJS.com significantly faster

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Apr 8, 2021
@TylerBarnes TylerBarnes requested a review from DanielSLew April 8, 2021 23:51
@TylerBarnes TylerBarnes added topic: source-wordpress Related to Gatsby's integration with WordPress and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Apr 8, 2021
Copy link
Contributor

@DanielSLew DanielSLew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! There's one failing test ci/circleci: e2e_tests_pnp, it doesn't look like this is related though.

@TylerBarnes TylerBarnes merged commit bb25e5b into master Apr 13, 2021
@TylerBarnes TylerBarnes deleted the fix/wp-invalidate-less-preview-queries branch April 13, 2021 16:03
@TylerBarnes
Copy link
Contributor Author

Thanks @DanielSLew !

moonmeister added a commit that referenced this pull request Apr 14, 2021
* master: (183 commits)
  chore(gatsby-plugin-image): Remove version note (#30758)
  docs: retire 'How to Create Pages' stub and Recipes landing page (#30842)
  chore(docs): Fix typo (#30858)
  docs: fix invalid mailto links in 3.3 release notes (#30862)
  docs: release notes for 3.3 (#30837)
  fix(gatsby-source-wordpress): invalidate less queries during previews (#30770)
  fix(gatsby-starter-wordpress-blog): Fix altText (#30832)
  feat(contentful): warn users when using restricted content type names (#30715)
  Refactor: using-contentful to use gatsby-plugin-image exclusively (#30717)
  chore(gatsby-plugin-styled-components): Remove breaking changes section (#30806)
  fix(gatsby): webpack warnings are no longer in object format by default (#30801)
  fix(gatsby): Decode base path in runtime (#30682)
  fix(gatsby): "Cannot find module 'babel-preset-gatsby'" error (#30813)
  handle plugin parentDir resolution in resolvePlugin() (#30812)
  Port using-gatsby-image site to image plugin (#28489)
  fix(gatsby-source-contentful): De-dupe type names (#30834)
  feat(gatsby): Add aggregation resolvers (#30789)
  fix(gatsby-core-utils): fetch-remote-file download failure when missing content-length header (#30810)
  fix(renovate): add breaking minor updates to major updates list (#30676)
  chore(docs): Update migration guide for plugins that support both v2 & v3 (#30825)
  ...
vladar pushed a commit that referenced this pull request Apr 19, 2021
vladar pushed a commit that referenced this pull request Apr 19, 2021
@vladar
Copy link
Contributor

vladar commented Apr 19, 2021

Published in [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: source-wordpress Related to Gatsby's integration with WordPress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants