fix(gatsby,gatsby-plugin-offline): register offline plugin when not on preview #30984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wardpeet
added
status: awaiting reviewer response
gatsbot
bot
added
the
status: triage needed
wardpeet
removed
the
status: triage needed
pieh
approved these changes
Apr 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changed the logic in gatsby to filter falsy values from "registerServiceWorker". We check for the length on the array and not which value they return.
With filter(Boolean) we do check if all values are falsy. There is one caveat still that we need to fix in a follow up PR. The code of the service worker that should not be installed will still be present in code as Gatsby api runner is not checking that piece.
Documentation
Related Issues