Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gatsby): don't print out flag suggestions if none are enabled or opted-in #31299

Merged
merged 1 commit into from
May 7, 2021

Conversation

pieh
Copy link
Contributor

@pieh pieh commented May 6, 2021

Description

gatsby develop due to some LOCKED_IN flag was always priting other flag suggestions even tho there was no explicit flags enabled by users or flags auto opted-in (both of which would print some message). It was resulting in confusing output like:

$ gatsby develop
info

There are 6 other flags available that you might be interested in:
- FAST_DEV · Enable all experiments aimed at improving develop server start time
- DEV_SSR · (Umbrella Issue (https://gatsby.dev/dev-ssr-feedback)) · Server Side Render (SSR) pages on full reloads during develop. Helps you detect SSR bugs
and fix them without needing to do full builds.
- PRESERVE_WEBPACK_CACHE · (Umbrella Issue (https://gatsby.dev/cache-clearing-feedback)) · Use webpack's persistent caching and don't delete webpack's cache
when changing gatsby-node.js & gatsby-config.js files.
- PRESERVE_FILE_DOWNLOAD_CACHE · (Umbrella Issue (https://gatsby.dev/cache-clearing-feedback)) · Don't delete the downloaded files cache when changing
gatsby-node.js & gatsby-config.js files.
- PARALLEL_SOURCING · EXPERIMENTAL · (Umbrella Issue (https://gatsby.dev/parallel-sourcing-feedback)) · Run all source plugins at the same time instead of
serially. For sites with multiple source plugins, this can speedup sourcing and transforming considerably.
- FUNCTIONS · EXPERIMENTAL · (Umbrella Issue (https://gatsby.dev/functions-feedback)) · Compile Serverless functions in your Gatsby project and write them to
disk, ready to deploy to Gatsby Cloud

success open and validate gatsby-configs - 0.110s

This PR checks wether there is any message related to flags before trying to even suggest other flags

Related Issues

Fixes regression introduced in #30992

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label May 6, 2021
@pieh pieh added topic: cli Related to the Gatsby CLI and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels May 6, 2021
@pieh pieh force-pushed the fix/flags-dont-just-suggest-other-flags branch from d58b5f7 to 93055fa Compare May 7, 2021 09:13
Copy link
Contributor

@LekoArts LekoArts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@LekoArts LekoArts merged commit 48eea6f into master May 7, 2021
@LekoArts LekoArts deleted the fix/flags-dont-just-suggest-other-flags branch May 7, 2021 11:12
vladar pushed a commit that referenced this pull request May 11, 2021
vladar pushed a commit that referenced this pull request May 11, 2021
…opted-in (#31299) (#31362)

(cherry picked from commit 48eea6f)

Co-authored-by: Michal Piechowiak <[email protected]>
This was referenced Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: cli Related to the Gatsby CLI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants