-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(gatsby): don't print out flag suggestions if none are enabled or opted-in #31299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
Issue or pull request that need to be triaged and assigned to a reviewer
label
May 6, 2021
pieh
added
topic: cli
Related to the Gatsby CLI
and removed
status: triage needed
Issue or pull request that need to be triaged and assigned to a reviewer
labels
May 6, 2021
pieh
force-pushed
the
fix/flags-dont-just-suggest-other-flags
branch
from
May 7, 2021 09:13
d58b5f7
to
93055fa
Compare
LekoArts
approved these changes
May 7, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
vladar
pushed a commit
that referenced
this pull request
May 11, 2021
…opted-in (#31299) (#31362) (cherry picked from commit 48eea6f) Co-authored-by: Michal Piechowiak <[email protected]>
axe312ger
pushed a commit
that referenced
this pull request
May 20, 2021
This was referenced Mar 13, 2022
This was referenced Mar 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
gatsby develop
due to someLOCKED_IN
flag was always priting other flag suggestions even tho there was no explicit flags enabled by users or flags auto opted-in (both of which would print some message). It was resulting in confusing output like:This PR checks wether there is any message related to flags before trying to even suggest other flags
Related Issues
Fixes regression introduced in #30992