fix(gatsby): correct hasNextPage pagination info when resultOffset is provided #32319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
vladar
added
topic: GraphQL
vladar
changed the title
vladar
added
the
bot: merge on green
|
Thanks @vladar! |
gatsbybot
pushed a commit
that referenced
this pull request
Jul 16, 2021
… provided (#32319) (#32386) (cherry picked from commit 9f8a580) Co-authored-by: Angelo Ashmore <[email protected]>
gatsbybot
pushed a commit
that referenced
this pull request
Jul 23, 2021
LekoArts
pushed a commit
that referenced
this pull request
Jul 26, 2021
LekoArts
pushed a commit
that referenced
this pull request
Jul 26, 2021
* Revert "fix(gatsby): correct hasNextPage pagination info when resultOffset is provided (#32319)" This reverts commit 9f8a580 * fix(gatsby): fixed pagination logic * try to make tests less confusing (cherry picked from commit 2dbe647) Co-authored-by: Vladimir Razuvaev <[email protected]>
This was referenced Oct 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the
hasNextPagefield in thepageInfodata for paginated queries. When querying for paginated content usingskipandlimit, thehasNextPagefield was returningfalsefor anything other than the first page, even if it a next page of nodes exists.Example query:
{ allPrismicPage(limit: 2 skip: 2) { nodes { id } pageInfo { hasNextPage } } }If there were a total of 6 nodes,
hasNextPagewas returningfalse. It now returnstrue.The logic for determining the value of
hasNextPageis edited in this PR and includes comments describing the logic.Documentation
Existing documentation: https://www.gatsbyjs.com/docs/schema-root-fields/#pagination-types
There is no need to update the documentation as this is a bug fix.
Related Issues
None